Merge pull request WayofTime#1997 from VT-14/No-Momentum-Reset-from-Sacrifice-Damage

WayofTime · web-flow · commit f41d1e0c12f5 · 2024-01-22T11:34:29.000-05:00
Add Sacrifice to "No Impact" Damage Type Tag
diff --git a/src/generated/resources/data/minecraft/tags/damage_type/no_impact.json b/src/generated/resources/data/minecraft/tags/damage_type/no_impact.json
@@ -0,0 +1,5 @@
+{
+  "values": [
+    "bloodmagic:sacrifice"
+  ]
+}
diff --git a/src/main/java/wayoftime/bloodmagic/common/data/GeneratorDamageTags.java b/src/main/java/wayoftime/bloodmagic/common/data/GeneratorDamageTags.java
@@ -21,5 +21,6 @@ public GeneratorDamageTags(PackOutput output, CompletableFuture<HolderLookup.Pro
     protected void addTags(HolderLookup.Provider provider) {
         this.tag(DamageTypeTags.BYPASSES_ARMOR).add(BloodMagicDamageTypes.SACRIFICE).add(BloodMagicDamageTypes.RITUAL);
         this.tag(DamageTypeTags.BYPASSES_EFFECTS).add(BloodMagicDamageTypes.SACRIFICE);
+        this.tag(DamageTypeTags.NO_IMPACT).add(BloodMagicDamageTypes.SACRIFICE);
     }
 }

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +{
 +  "values": [
 +    "bloodmagic:sacrifice"
 +  ]
 +}
Original file line number	Diff line number	Diff line change
`@@ -21,5 +21,6 @@ public GeneratorDamageTags(PackOutput output, CompletableFuture<HolderLookup.Pro`
`21`	`21`	`protected void addTags(HolderLookup.Provider provider) {`
`22`	`22`	`this.tag(DamageTypeTags.BYPASSES_ARMOR).add(BloodMagicDamageTypes.SACRIFICE).add(BloodMagicDamageTypes.RITUAL);`
`23`	`23`	`this.tag(DamageTypeTags.BYPASSES_EFFECTS).add(BloodMagicDamageTypes.SACRIFICE);`
	`24`	`+ this.tag(DamageTypeTags.NO_IMPACT).add(BloodMagicDamageTypes.SACRIFICE);`
`24`	`25`	`}`
`25`	`26`	`}`