Code quality

Author: florianbecker

examples/configuration/main.cpp

@@ -83,14 +83,11 @@ int main() {
   logSomeMessages();
 
   /* remove tmp file */
-  bool removed = std::filesystem::remove( tmpFile );
-  if ( !removed ) {
+  if ( !std::filesystem::remove( tmpFile ) ) {
 
     std::cout << "Tmp file cannot be removed: " << tmpFile << std::endl;
     return EXIT_FAILURE;
   }
   std::cout << "Tmp file was removed: " << tmpFile << std::endl;
   return EXIT_SUCCESS;
-
-  return EXIT_SUCCESS;
 }

examples/threads/main.cpp

@@ -102,8 +102,7 @@ int main() {
   threads.clear();
 
   /* remove tmp file */
-  bool removed = std::filesystem::remove( tmpFile );
-  if ( !removed ) {
+  if ( !std::filesystem::remove( tmpFile ) ) {
 
     std::cout << "Tmp file cannot be removed: " << tmpFile << std::endl;
     return EXIT_FAILURE;

source/Logger.h

@@ -85,7 +85,7 @@ namespace vx {
    * @brief Create thread-safe timestamp.
    * @return Timestamp as 'Y-m-dThh:mm:ss.xxxxxx'
    */
-  inline const std::string timestamp() noexcept {
+  inline std::string timestamp() noexcept {
 
     /* get a precise timestamp as a string */
     struct std::tm currentLocalTime {};

tests/shared/TestHelper.cpp

@@ -31,6 +31,7 @@
 /* stl header */
 #include <algorithm>
 #include <fstream>
+#include <iostream>
 
 /* local header */
 #include "TestHelper.h"
@@ -51,7 +52,7 @@ namespace vx::TestHelper {
       catch ( [[maybe_unused]] const std::exception &_exception ) {
 
         /* nothing to do, file cannot be closed. */
-//        std::cout << _exception.what() << std::endl;
+        std::cout << _exception.what() << std::endl;
       }
     }
     return count;

tests/simple/SimpleFileLogger.cpp

@@ -119,8 +119,7 @@ namespace vx {
 
       std::size_t count = TestHelper::countNewLines( tmpFile );
 
-      bool removed = std::filesystem::remove( tmpFile );
-      if ( !removed ) {
+      if ( !std::filesystem::remove( tmpFile ) ) {
 
         CPPUNIT_FAIL( "Tmp file cannot be removed: " + tmpFile );
       }

tests/simple/SimpleXmlLogger.cpp

@@ -118,8 +118,7 @@ namespace vx {
 
       std::size_t count = TestHelper::countNewLines( tmpFile );
 
-      bool removed = std::filesystem::remove( tmpFile );
-      if ( !removed ) {
+      if ( !std::filesystem::remove( tmpFile ) ) {
 
         CPPUNIT_FAIL( "Tmp file cannot be removed: " + tmpFile );
       }

tests/threads/ThreadsFileLogger.cpp

@@ -110,7 +110,7 @@ namespace vx {
       threads.reserve( hardwareThreadCount );
       for ( unsigned int n = 0; n < hardwareThreadCount; ++n ) {
 
-        threads.emplace_back( std::thread( [&] {
+        threads.emplace_back( std::thread( [&hardwareThreadCount] {
 
           std::ostringstream s;
           s << logMessage;
@@ -135,8 +135,7 @@ namespace vx {
 
       std::size_t count = TestHelper::countNewLines( tmpFile );
 
-      bool removed = std::filesystem::remove( tmpFile );
-      if ( !removed ) {
+      if ( !std::filesystem::remove( tmpFile ) ) {
 
         CPPUNIT_FAIL( "Tmp file cannot be removed: " + tmpFile );
       }

tests/threads/ThreadsNullLogger.cpp

@@ -93,7 +93,7 @@ namespace vx {
       threads.reserve( hardwareThreadCount );
       for ( unsigned int n = 0; n < hardwareThreadCount; ++n ) {
 
-        threads.emplace_back( std::thread( [&] {
+        threads.emplace_back( std::thread( [&hardwareThreadCount] {
 
           std::ostringstream s;
           s << logMessage;

tests/threads/ThreadsStdLogger.cpp

@@ -93,7 +93,7 @@ namespace vx {
       threads.reserve( hardwareThreadCount );
       for ( unsigned int n = 0; n < hardwareThreadCount; ++n ) {
 
-        threads.emplace_back( std::thread( [&] {
+        threads.emplace_back( std::thread( [&hardwareThreadCount] {
 
           std::ostringstream s;
           s << logMessage;

tests/threads/ThreadsXmlLogger.cpp

@@ -109,7 +109,7 @@ namespace vx {
       threads.reserve( hardwareThreadCount );
       for ( unsigned int n = 0; n < hardwareThreadCount; ++n ) {
 
-        threads.emplace_back( std::thread( [&] {
+        threads.emplace_back( std::thread( [&hardwareThreadCount] {
 
           std::ostringstream s;
           s << logMessage;
@@ -134,8 +134,7 @@ namespace vx {
 
       std::size_t count = TestHelper::countNewLines( tmpFile );
 
-      bool removed = std::filesystem::remove( tmpFile );
-      if ( !removed ) {
+      if ( !std::filesystem::remove( tmpFile ) ) {
 
         CPPUNIT_FAIL( "Tmp file cannot be removed: " + tmpFile );
       }