Fix unused std err member for std logger

Code quality

Author: florianbecker

examples/simple/main.cpp

@@ -43,7 +43,7 @@ constexpr auto logMessage = "This is a log message";
 int main() {
 
   /* configure logging, if you dont it defaults to standard out logging with colors */
-  ConfigureLogger( { { "type", "std" }, { "color", "true" } } );
+  ConfigureLogger( { { "type", "std" }, { "color", "true" }, { "stderr", "true" } } );
 
   /* Log some messages */
   LogFatal( logMessage );

source/FileLogger.cpp

@@ -30,6 +30,7 @@
 
 /* stl header */
 #include <algorithm>
+#include <iostream>
 #include <mutex>
 
 /* magic enum */
@@ -70,17 +71,20 @@ namespace vx {
 
         m_reopenInterval = std::chrono::seconds( std::stoul( interval->second ) );
       }
-      catch ( [[maybe_unused]] const std::invalid_argument &_exception ) {
+      catch ( const std::invalid_argument &_exception ) {
 
+        std::cout << _exception.what() << std::endl;
         throw std::invalid_argument( interval->second + " is not a valid reopen interval." );
       }
-      catch ( [[maybe_unused]] const std::out_of_range &_exception ) {
+      catch ( const std::out_of_range &_exception ) {
 
+        std::cout << _exception.what() << std::endl;
         throw std::out_of_range( interval->second + " is out of range reopen interval." );
       }
-      catch ( [[maybe_unused]] const std::exception &_exception ) {
+      catch ( const std::exception &_exception ) {
 
         /* nothing to do */
+        std::cout << _exception.what() << std::endl;
       }
     }
 
@@ -99,9 +103,10 @@ namespace vx {
         m_file.close();
       }
     }
-    catch ( [[maybe_unused]] const std::exception &_exception ) {
+    catch ( const std::exception &_exception ) {
 
       /* nothing to do, file cannot be closed. */
+      std::cout << _exception.what() << std::endl;
     }
   }
 
@@ -119,7 +124,7 @@ namespace vx {
     output.append( timestamp() );
 
     std::string severity( magic_enum::enum_name( _severity ) );
-    std::transform( std::begin( severity ), std::end( severity ), std::begin( severity ), []( auto c ) { return ::toupper( c ); } );
+    std::transform( std::begin( severity ), std::end( severity ), std::begin( severity ), []( auto c ) { return std::toupper( c ); } );
     output.append( " [" + severity + "] " );
     if ( std::string( _location.file_name() ) != "unsupported" ) {
 
@@ -166,9 +171,10 @@ namespace vx {
         }
         m_file.open( m_filename, std::ofstream::out | std::ofstream::app );
       }
-      catch ( [[maybe_unused]] const std::exception &_exception ) {
+      catch ( const std::exception &_exception ) {
 
         /* nothing to do, file is not open or cannot be closed. */
+        std::cout << _exception.what() << std::endl;
       }
       m_lastReopen = std::chrono::system_clock::now();
     }

source/LoggerFactory.cpp

@@ -49,13 +49,13 @@ namespace vx {
       m_creators.try_emplace( "file", []( const std::unordered_map<std::string, std::string> &_configuration ) -> std::unique_ptr<Logger> { return std::make_unique<FileLogger>( _configuration ); } );
       m_creators.try_emplace( "xml", []( const std::unordered_map<std::string, std::string> &_configuration ) -> std::unique_ptr<Logger> { return std::make_unique<XmlFileLogger>( _configuration ); } );
     }
-    catch ( [[maybe_unused]] const std::bad_alloc &_exception ) {
+    catch ( const std::bad_alloc &_exception ) {
 
-      /* _exception.what() */
+      std::cout << _exception.what() << std::endl;
     }
-    catch ( [[maybe_unused]] const std::exception &_exception ) {
+    catch ( const std::exception &_exception ) {
 
-      /* _exception.what() */
+      std::cout << _exception.what() << std::endl;
     }
   }
 

source/StdLogger.cpp

@@ -65,7 +65,7 @@ namespace vx {
     output.append( timestamp() );
 
     std::string severity( magic_enum::enum_name( _severity ) );
-    std::transform( std::begin( severity ), std::end( severity ), std::begin( severity ), []( auto c ) { return ::toupper( c ); } );
+    std::transform( std::begin( severity ), std::end( severity ), std::begin( severity ), []( auto c ) { return std::toupper( c ); } );
     if ( m_useColor ) {
 
       switch ( _severity ) {
@@ -121,7 +121,16 @@ namespace vx {
     /* though, we make sure to only call the << operator once on std::cout */
     /* otherwise the << operators from different threads could interleave */
     /* obviously we dont care if flushes interleave */
-    std::cout << _message;
+    std::string message( _message );
+    /* Not optimal to use find here, so if a message contains [FATAL] as text, it will match here */
+    if ( m_useStdErr && ( message.find( "[FATAL]" ) != std::string::npos || message.find( "[ERROR]" ) != std::string::npos ) ) {
+
+      std::cerr << _message;
+    }
+    else {
+
+      std::cout << _message;
+    }
     std::cout.flush();
   }
 }

source/XmlFileLogger.cpp

@@ -76,7 +76,7 @@ namespace vx {
     }
 
     std::string severity( magic_enum::enum_name( _severity ) );
-    std::transform( std::begin( severity ), std::end( severity ), std::begin( severity ), []( auto c ) { return ::toupper( c ); } );
+    std::transform( std::begin( severity ), std::end( severity ), std::begin( severity ), []( auto c ) { return std::toupper( c ); } );
     output.append( "<severity>" );
     output.append( severity );
     output.append( "</severity>" );

tests/simple/SimpleFileLogger.cpp

@@ -150,9 +150,10 @@ int main() {
 
     xmlFileOut.close();
   }
-  catch ( [[maybe_unused]] const std::exception &_exception ) {
+  catch ( const std::exception &_exception ) {
 
     /* Do not throw exception here */
+    std::cout << _exception.what() << std::endl;
   }
 
   return wasSuccessful ? 0 : 1;

tests/simple/SimpleNullLogger.cpp

@@ -122,9 +122,10 @@ int main() {
 
     xmlFileOut.close();
   }
-  catch ( [[maybe_unused]] const std::exception &_exception ) {
+  catch ( const std::exception &_exception ) {
 
     /* Do not throw exception here */
+    std::cout << _exception.what() << std::endl;
   }
 
   return wasSuccessful ? 0 : 1;

tests/simple/SimpleStdLogger.cpp

@@ -122,9 +122,10 @@ int main() {
 
     xmlFileOut.close();
   }
-  catch ( [[maybe_unused]] const std::exception &_exception ) {
+  catch ( const std::exception &_exception ) {
 
     /* Do not throw exception here */
+    std::cout << _exception.what() << std::endl;
   }
 
   return wasSuccessful ? 0 : 1;

tests/simple/SimpleXmlLogger.cpp

@@ -149,9 +149,10 @@ int main() {
 
     xmlFileOut.close();
   }
-  catch ( [[maybe_unused]] const std::exception &_exception ) {
+  catch ( const std::exception &_exception ) {
 
     /* Do not throw exception here */
+    std::cout << _exception.what() << std::endl;
   }
 
   return wasSuccessful ? 0 : 1;

tests/threads/ThreadsFileLogger.cpp

@@ -166,9 +166,10 @@ int main() {
 
     xmlFileOut.close();
   }
-  catch ( [[maybe_unused]] const std::exception &_exception ) {
+  catch ( const std::exception &_exception ) {
 
     /* Do not throw exception here */
+    std::cout << _exception.what() << std::endl;
   }
 
   return wasSuccessful ? 0 : 1;