Fix windows build

Author: florianbecker

cmake/env.cmake

@@ -97,6 +97,8 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
   if(CMAKE_CXX_FLAGS MATCHES "/W[0-4]")
     string(REGEX REPLACE "/W[0-4]" "/W4" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}")
   endif()
+
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${WARNING_FLAGS_SPACED}")
 endif()
 
 add_compile_options("$<$<CONFIG:DEBUG>:-DDEBUG>")

cmake/msvc_warnings.cmake

@@ -29,4 +29,10 @@
 #
 
 set(WARNING_FLAGS
+
+  # possible loss of data
+  /wd4244
+
+  # convert int to size_t
+  /wd4267
 )

source/Logger.h

@@ -80,11 +80,17 @@ namespace vx {
     const auto nowAsTimeT = std::chrono::system_clock::to_time_t( now );
     const auto nowMs = std::chrono::duration_cast<std::chrono::microseconds>( now.time_since_epoch() ) % 1000000;
 
+#ifdef _WIN32
+  localtime_s(&currentLocalTime, &nowAsTimeT);
+#else
+  localtime_r(&nowAsTimeT, &currentLocalTime);
+#endif
+
     std::ostringstream nowSs;
     nowSs
-        << std::put_time( localtime_r( &nowAsTimeT, &currentLocalTime ), "%Y-%m-%dT%T" )
+        << std::put_time( &currentLocalTime, "%Y-%m-%dT%T" )
         << '.' << std::setfill( '0' ) << std::setw( 6 ) << nowMs.count()
-        << std::put_time( localtime_r( &nowAsTimeT, &currentLocalTime ), "%z" );
+        << std::put_time( &currentLocalTime, "%z" );
     std::string result = nowSs.str();
     /* somewhat special - maybe see systemtimeformatter */
     result.replace( result.end() - 2, result.end() - 2, ":" );