Skip to content

Commit d06699c

Browse files
committed
organized codebase, added pytest cases
1 parent 71b431d commit d06699c

File tree

17 files changed

+754
-1003
lines changed

17 files changed

+754
-1003
lines changed

.github/workflows/cowsay.yaml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,14 @@ jobs:
88
runs-on: ubuntu-latest
99
strategy:
1010
matrix:
11-
python-version: [3.6, 3.7, 3.8, 3.9]
11+
python-version: ["3.8", "3.9", "3.10", "3.11"]
1212

1313
steps:
1414
- uses: actions/checkout@v2
1515
- name: Set up Python ${{ matrix.python-version }}
1616
uses: actions/setup-python@v2
1717
with:
1818
python-version: ${{ matrix.python-version }}
19-
- name: Install dependencies
19+
- name: Test with Pytest
2020
run: |
21-
python -m pip install --upgrade pip
22-
- name: Test with unittest
23-
run: |
24-
python -m unittest
21+
pytest

.gitignore

Lines changed: 160 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,160 @@
1-
.vscode
2-
venv
3-
build
4-
dist
5-
*egg-info
6-
__pycache__/
1+
# Byte-compiled / optimized / DLL files
2+
__pycache__/
3+
*.py[cod]
4+
*$py.class
5+
6+
# C extensions
7+
*.so
8+
9+
# Distribution / packaging
10+
.Python
11+
build/
12+
develop-eggs/
13+
dist/
14+
downloads/
15+
eggs/
16+
.eggs/
17+
lib/
18+
lib64/
19+
parts/
20+
sdist/
21+
var/
22+
wheels/
23+
share/python-wheels/
24+
*.egg-info/
25+
.installed.cfg
26+
*.egg
27+
MANIFEST
28+
29+
# PyInstaller
30+
# Usually these files are written by a python script from a template
31+
# before PyInstaller builds the exe, so as to inject date/other infos into it.
32+
*.manifest
33+
*.spec
34+
35+
# Installer logs
36+
pip-log.txt
37+
pip-delete-this-directory.txt
38+
39+
# Unit test / coverage reports
40+
htmlcov/
41+
.tox/
42+
.nox/
43+
.coverage
44+
.coverage.*
45+
.cache
46+
nosetests.xml
47+
coverage.xml
48+
*.cover
49+
*.py,cover
50+
.hypothesis/
51+
.pytest_cache/
52+
cover/
53+
54+
# Translations
55+
*.mo
56+
*.pot
57+
58+
# Django stuff:
59+
*.log
60+
local_settings.py
61+
db.sqlite3
62+
db.sqlite3-journal
63+
64+
# Flask stuff:
65+
instance/
66+
.webassets-cache
67+
68+
# Scrapy stuff:
69+
.scrapy
70+
71+
# Sphinx documentation
72+
docs/_build/
73+
74+
# PyBuilder
75+
.pybuilder/
76+
target/
77+
78+
# Jupyter Notebook
79+
.ipynb_checkpoints
80+
81+
# IPython
82+
profile_default/
83+
ipython_config.py
84+
85+
# pyenv
86+
# For a library or package, you might want to ignore these files since the code is
87+
# intended to run in multiple environments; otherwise, check them in:
88+
# .python-version
89+
90+
# pipenv
91+
# According to pypa/pipenv#598, it is recommended to include Pipfile.lock in version control.
92+
# However, in case of collaboration, if having platform-specific dependencies or dependencies
93+
# having no cross-platform support, pipenv may install dependencies that don't work, or not
94+
# install all needed dependencies.
95+
#Pipfile.lock
96+
97+
# poetry
98+
# Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control.
99+
# This is especially recommended for binary packages to ensure reproducibility, and is more
100+
# commonly ignored for libraries.
101+
# https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control
102+
#poetry.lock
103+
104+
# pdm
105+
# Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control.
106+
#pdm.lock
107+
# pdm stores project-wide configurations in .pdm.toml, but it is recommended to not include it
108+
# in version control.
109+
# https://pdm.fming.dev/#use-with-ide
110+
.pdm.toml
111+
112+
# PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm
113+
__pypackages__/
114+
115+
# Celery stuff
116+
celerybeat-schedule
117+
celerybeat.pid
118+
119+
# SageMath parsed files
120+
*.sage.py
121+
122+
# Environments
123+
.env
124+
.venv
125+
env/
126+
venv/
127+
ENV/
128+
env.bak/
129+
venv.bak/
130+
131+
# Spyder project settings
132+
.spyderproject
133+
.spyproject
134+
135+
# Rope project settings
136+
.ropeproject
137+
138+
# mkdocs documentation
139+
/site
140+
141+
# mypy
142+
.mypy_cache/
143+
.dmypy.json
144+
dmypy.json
145+
146+
# Pyre type checker
147+
.pyre/
148+
149+
# pytype static type analyzer
150+
.pytype/
151+
152+
# Cython debug symbols
153+
cython_debug/
154+
155+
# PyCharm
156+
# JetBrains specific template is maintained in a separate JetBrains.gitignore that can
157+
# be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore
158+
# and can be added to the global gitignore or merged into this file. For a more nuclear
159+
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
160+
#.idea/

.idea/cowsay-python.iml

Lines changed: 11 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.idea/misc.xml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

CHANGELOG.md

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,23 @@
1-
Change Log
2-
==========
1+
# Change Log
32

43
All notable changes to this project will be documented in this file
54

65
___
76

7+
## v6.0 (Sep 15, 2023)
8+
9+
## Added
10+
- Added CONTRIBUTING.md guide on how to add new characters
11+
- Exposed `cowsay.draw` method to draw custom characters
12+
- <b>New character</b>: Octopus (Added by [druhi](https://github.com/druhi))
13+
14+
## Changed
15+
- Dropped support for Python 3.6 and 3.7
16+
- Updated to use pytest and added more tests!
17+
- Simplified the entire codebase and removed unnecessary files
18+
19+
___
20+
821
## v5.0 (Jun 21, 2022)
922

1023
## Added
@@ -36,7 +49,7 @@ ___
3649

3750
## Added
3851
- <b>New character</b>: Pig (Added by [Gerald Sornsen](https://github.com/gsornsen))<br>
39-
- Command line compatability (Added by [Chad Smith](https://github.com/cs01))
52+
- Command line compatibility (Added by [Chad Smith](https://github.com/cs01))
4053

4154
___
4255

CONTRIBUTING.md

Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,62 @@
1+
# Adding a new Character
2+
1. Choose the new character and first test it's output using `cowsay.draw` method
3+
```
4+
# https://www.asciiart.eu/animals
5+
6+
>>> scorpion = r"""
7+
\
8+
\
9+
\
10+
___ ___
11+
( _< >_ )
12+
// \\
13+
\\___..___//
14+
`-( )-'
15+
_|__|_
16+
/_|__|_\
17+
/_|__|_\
18+
/_\__/_\
19+
\ || / _)
20+
|| ( )
21+
\\___//
22+
`---'
23+
"""
24+
25+
>>> cowsay.draw('Hello I am Scorpion', scorpion)
26+
___________________
27+
| Hello I am Scorpion |
28+
===================
29+
\
30+
\
31+
\
32+
___ ___
33+
( _< >_ )
34+
// \\
35+
\\___..___//
36+
`-( )-'
37+
_|__|_
38+
/_|__|_\
39+
/_|__|_\
40+
/_\__/_\
41+
\ || / _)
42+
|| ( )
43+
\\___//
44+
`---'
45+
```
46+
2. Fork the repo here https://github.com/VaasuDevanS/cowsay-python/fork
47+
3. Once the character and it's output are finalized, add the character in
48+
`cowsay/characters.py` and it's expected solution in `cowsay/tests/solutions.py`
49+
4. Add the character name in `test_char_names` function in `cowsay/tests/test_api.py`
50+
5. Update `README.md` (`More Characters` section)
51+
6. Run the test suite locally using `pytest`
52+
7. Create a `Pull Request`
53+
54+
55+
# Updating the codebase
56+
Feel free to create a pull request to make any desired changes
57+
to the code without breaking the API :-)
58+
59+
60+
# Adding new functionality
61+
Feel free to create a pull request if you want to add more
62+
functionality (like customizations to each characters, ...)

0 commit comments

Comments
 (0)