TNR-1756: Quotes and Reservations (#20)

* TNR-1756: Quotes and Reservations

- Also bump version of `requests` due to CVE-2018-18074

* TNR-1756: Ensure https since we handle sensitive info

* feng shui

* `unit_id`s are `int`s now

Author: bijan-vacasa

Pipfile

@@ -7,9 +7,7 @@ name = "pypi"
 backoff = "*"
 pendulum = "*"
 requests = "*"
-
-[dev-packages]
 pytest = "*"
 
 [requires]
-python_version = "3.6"
+python_version = "3.6"

Pipfile.lock

@@ -2,15 +2,15 @@
 
 setup(
     name='VacasaConnect',
-    version='0.3.0',
+    version='0.4.0',
     description='A Python 3.6 SDK for the connect.vacasa.com API.',
     packages=['vacasa.connect'],
     url='https://github.com/Vacasa/python-vacasa-connect-sdk',
     license='MIT',
     install_requires=[
         'pendulum==2.*',
         'backoff~=1.6',
-        'requests==2.*'
+        'requests>=2.20.0'
     ],
     long_description=open('README.md').read()
 )

setup.py

@@ -1,55 +1,63 @@
-import pendulum
 from unittest.mock import patch, MagicMock
 
+import pendulum
+import pytest
+
 from vacasa.connect import VacasaConnect
 
+fake_access_token = {
+    'access_token': 'fake_access_token',
+    'expires_at': pendulum.now().add(days=1).to_datetime_string()
+}
+fake_refresh_token = {
+    'refresh_token': 'fake_refresh_token',
+    'expires_at': pendulum.now().add(days=1).to_datetime_string()
+}
+
+
+@patch.object(VacasaConnect, '_populate_tokens')
+def mock_connect(mock_populate_tokens):
+    connect = VacasaConnect('fake_key', 'fake_secret', 'https://fake_url')
+
+    # mock call that generates tokens
+    mock_response = MagicMock()
+    mock_response.return_value = None
+    mock_populate_tokens.return_value = mock_response
+
+    # populate fake tokens
+    connect._access_token = fake_access_token
+    connect._refresh_token = fake_refresh_token
 
-class TestVacasaConnect(object):
+    return connect
 
-    fake_access_token = {
-        'access_token': 'fake_access_token',
-        'expires_at': pendulum.now().add(days=1).to_datetime_string()
-    }
-    fake_refresh_token = {
-        'refresh_token': 'fake_refresh_token',
-        'expires_at': pendulum.now().add(days=1).to_datetime_string()
-    }
 
-    @patch.object(VacasaConnect, '_populate_tokens')
-    def mock_connect(self, mock_populate_tokens):
-        connect = VacasaConnect('fake_key', 'fake_secret', 'fake_url')
+def test_generate_signature():
+    connect = mock_connect()
+    timestamp = int(pendulum.datetime(2017, 1, 1, 0, 0).timestamp())
+    signature = connect._generate_signature(timestamp)
+    expected = '87446b676b79b6e493a6b852ec3c32faf579086bd12728178197ef278ec7abfc'
 
-        # mock call that generates tokens
-        mock_response = MagicMock()
-        mock_response.return_value = None
-        mock_populate_tokens.return_value = mock_response
+    assert signature == expected
 
-        # populate fake tokens
-        connect._access_token = self.fake_access_token
-        connect._refresh_token = self.fake_refresh_token
 
-        return connect
+def test_add_meta_param_adds_one_to_empty():
+    connect = mock_connect()
+    params = {}
+    params = connect._add_meta_param(params, 'include_photos')
+    expected = {'include_meta': ',include_photos'}
 
-    def test_generate_signature(self):
-        connect = self.mock_connect()
-        timestamp = int(pendulum.datetime(2017, 1, 1, 0, 0).timestamp())
-        signature = connect._generate_signature(timestamp)
-        expected = '87446b676b79b6e493a6b852ec3c32faf579086bd12728178197ef278ec7abfc'
+    assert params == expected
 
-        assert signature == expected
 
-    def test_add_meta_param_adds_one_to_empty(self):
-        connect = self.mock_connect()
-        params = {}
-        params = connect._add_meta_param(params, 'include_photos')
-        expected = {'include_meta': ',include_photos'}
+def test_add_meta_param_adds_another_to_existing():
+    connect = mock_connect()
+    params = {'include_meta': ',include_photos'}
+    params = connect._add_meta_param(params, 'amenities_map')
+    expected = {'include_meta': ',include_photos,amenities_map'}
 
-        assert params == expected
+    assert params == expected
 
-    def test_add_meta_param_adds_another_to_existing(self):
-        connect = self.mock_connect()
-        params = {'include_meta': ',include_photos'}
-        params = connect._add_meta_param(params, 'amenities_map')
-        expected = {'include_meta': ',include_photos,amenities_map'}
 
-        assert params == expected
+def test_ensure_https():
+    with pytest.raises(ValueError):
+        VacasaConnect('fake_key', 'fake_secret', 'http://fake_endpoint')