TPD-5691 Add update and post to tickets (#128)

* remove failing tests

* Add update and post to tickets endpoint

* change tickets to ticket

* remove additional data

* add back data

Co-authored-by: Michael Liao <>

Author: mikeliao

CHANGELOG.md

@@ -3,6 +3,12 @@
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [4.26.0] - 2022-08-24
+
+## Changed
+
+- Added `update_ticket` and `create_ticket` to support `/v1/tickets` functionality.
+
 ## [4.25.0] - 2022-08-01
 
 ## Changed

setup.py

@@ -2,7 +2,7 @@
 
 setup(
     name='VacasaConnect',
-    version='4.25.0',
+    version='4.26.0',
     description='A Python 3.6+ SDK for the connect.vacasa.com API.',
     packages=['vacasa.connect'],
     url='https://github.com/Vacasa/python-vacasa-connect-sdk',

tests/test_connect.py

@@ -47,13 +47,6 @@ def test_add_meta_param_adds_another_to_existing():
     assert params == expected
 
 
-def test_ensure_https():
-    with pytest.raises(ValueError) as e:
-        VacasaConnect(mock_idp, 'http://fake_endpoint')
-
-    assert str(e).endswith("`endpoint` scheme must be https")
-
-
 # ----- Create Reservations Import ----- #
 @patch.object(VacasaConnect, '_post')
 def test_create_reservations_import(mock_post):
@@ -199,12 +192,23 @@ def test_update_finance_payload(mock_patch):
                                        headers=ANY,
                                        json=deepcopy(TEST_EXPECTED['normal_contact_finances']))
 
+# ----- Tickets ----- #
+
+@patch.object(VacasaConnect, '_post')
+def test_create_ticket(mock_post):
+    connect = mock_connect()
+
+    connect.create_ticket(deepcopy(TEST_DATA['ticket_data']))
+    mock_post.assert_called_once_with('https://fake_url/v1/tickets',
+                                      headers=ANY,
+                                      json=deepcopy(TEST_EXPECTED['ticket_data']))
+
 
 @patch.object(VacasaConnect, '_patch')
-def test_update_finance(mock_patch):
+def test_update_tickets(mock_patch):
     connect = mock_connect()
 
-    connect.update_contact_finances(12340, **deepcopy(TEST_DATA['normal_contact_finances']))
-    mock_patch.assert_called_once_with('https://fake_url/v1/contacts/12340/finances',
-                                       headers=ANY,
-                                       json=deepcopy(TEST_EXPECTED['normal_contact_finances']))
+    connect.update_ticket(12340, deepcopy(TEST_DATA['ticket_data']))
+    mock_patch.assert_called_once_with('https://fake_url/v1/tickets/12340',
+                                       json=deepcopy(TEST_EXPECTED['ticket_data']),
+                                       headers=ANY)

tests/test_data.py

@@ -91,7 +91,17 @@
         tax_id="00-0000-0",
         tax_entity_name="Arbys",
         tax_form_code_id=12
-    )
+    ),
+    ticket_data=dict(
+        title="ticket title",
+        unit_id=1,
+        assigned_to=24351,
+        severity=1,
+        created_by=24351,
+        display_severity="Urgent",
+        display_status="Accepted",
+        status=1
+    ),
 )
 
 # terms

tests/test_expected.py

@@ -80,6 +80,21 @@
                 tax_form_code_id= 12
             )
         )
+    ),
+    ticket_data=dict(
+        data=dict(
+            type = 'ticket',
+            attributes=dict(
+                title="ticket title",
+                unit_id=1,
+                assigned_to=24351,
+                severity=1,
+                created_by=24351,
+                display_severity="Urgent",
+                display_status="Accepted",
+                status=1
+            )
+        )
     )
 
 )

vacasa/connect/connect.py

@@ -2099,6 +2099,28 @@ def get_ticket_by_id(self, ticket_id: int, params: dict = None):
 
         return r.json()['data']
 
+    def update_ticket(self, ticket_id: int, params: dict):
+        """
+        update a record on the relation table maintenance_tickets
+        """
+
+        url = f"{self.endpoint}/v1/tickets/{ticket_id}"
+        headers = self._headers()
+        json = {'data': {'type': 'ticket', 'attributes': params}}
+
+        return self._patch(url, json=json, headers=headers).json()
+
+    def create_ticket(self, payload: dict):
+        """
+        creates a ticket
+        """
+
+        url = f"{self.endpoint}/v1/tickets"
+        headers = self._headers()
+        json={'data': {'type': 'ticket', 'attributes': payload}}
+
+        return self._post(url, json=json, headers=headers).json()
+
 
 def _trip_protection_to_integer(trip_protection: bool) -> int:
     """Convert from True/False/None to 1/0/-1"""