Skip to content

Commit d58f10b

Browse files
authored
GROW-965: Need to return the error payload! (#64)
* GROW-965: Need to return the error payload! * GROW-965: This is why we do reviews * GROW-965: rewinding some of the exception stuff
1 parent 00adea2 commit d58f10b

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@
33
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
44
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
55

6+
## [2.1.1] - 2019-08-23
7+
### Fixed
8+
- not calling .json() on financial patch call result
9+
10+
611
## [2.1.0] - 2019-08-19
712
### Added
813
- update_contact_finances()

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
setup(
44
name='VacasaConnect',
5-
version='2.1.0',
5+
version='2.1.1',
66
description='A Python 3.6+ SDK for the connect.vacasa.com API.',
77
packages=['vacasa.connect'],
88
url='https://github.com/Vacasa/python-vacasa-connect-sdk',

vacasa/connect/connect.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1253,7 +1253,7 @@ def update_contact_finances(self,
12531253
Sensitve data.. no result (HTTP-204)
12541254
12551255
"""
1256-
return self.update_contact_finances_payload(contact_id, dict(
1256+
self.update_contact_finances_payload(contact_id, dict(
12571257
account_name=account_name,
12581258
account_number=account_number,
12591259
routing_number=routing_number,
@@ -1277,7 +1277,7 @@ def update_contact_finances_payload(self, contact_id, params: dict):
12771277
"""
12781278

12791279
url = f"{self.endpoint}/v1/contacts/{contact_id}/finances"
1280-
return self._patch(url, json={'data': {'attributes': params}}, headers=self._headers()).json()
1280+
self._patch(url, json={'data': {'attributes': params}}, headers=self._headers())
12811281

12821282

12831283

0 commit comments

Comments
 (0)