Angular 19 Compatibility issue

[rcrafael]

After upgrading from Angular 18 to 19, I got issue in the ng2-pdf-viewer dependency PDFJS-DIST.
I already tried removing the caret(^) and downgrading this ng2-pdf-viewer from 10.4.0 to 10.2.2 (which is working in angular 18 previously) but still got the same error from the pdfjs-dist after serving the angular app.

anyone run into the same issue? or someone know the fix for this?

[dzonatan]

it seems to be angular-cli fault: angular/angular-cli#29077
I see they're working on a patch already

[joewIST]

@rcrafael A workaround is to add the packages to the externalDependencies array in the build options, e.g.:
"externalDependencies": [ "http", "https", "url", "util", "fs" ]

[shamoon]

I think this can be closed, the angular change above was merged and will presumably be released soon. The above only happens in certain situations I believe anyway.

Compatibility between Angular 18 and v10.4 of this package is covered in a separate issue already.

[rcrafael]

@rcrafael A workaround is to add the packages to the externalDependencies array in the build options, e.g.: "externalDependencies": [ "http", "https", "url", "util", "fs" ]

i have tried this workaround but i got different error after serving the application.

[dzonatan]

for the time being you can downgrade the @angular-devkit/build-angular to 19.0.3

[rcrafael]

for the time being you can downgrade the @angular-devkit/build-angular to 19.0.3

actually, i ended up downgrading to angular 18, i will wait for the version 19 to be stable.

thank for the response

[ricardosaracino]

Angular 19 is working fine for me less all this

4:25:49 PM [vite] (client) warning: 
C:/Users/Ric/Projects/orbulis-portal/.angular/cache/19.1.4/orbulis-portal/vite/deps/ng2-pdf-viewer.js
12150|        const worker = yield import(
12151|          /*webpackIgnore: true*/
12152|          this.workerSrc
   |          ^^^^^^^^^^^^^^
12153|        );
12154|        return worker.WorkerMessageHandler;
The above dynamic import cannot be analyzed by Vite.
See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning.

  Plugin: vite:import-analysis
  File: C:/Users/Ric/Projects/orbulis-portal/.angular/cache/19.1.4/orbulis-portal/vite/deps/ng2-pdf-viewer.js?v=2ae645d4
4:25:49 PM [vite] (client) warning: 
C:/Users/Ric/Projects/orbulis-portal/.angular/cache/19.1.4/orbulis-portal/vite/deps/ng2-pdf-viewer.js
26456|        const sandbox = import(
26457|          /*webpackIgnore: true*/
26458|          sandboxBundleSrc
   |          ^^^^^^^^^^^^^^^^
26459|        );
26460|        sandbox.then((pdfjsSandbox) => {
The above dynamic import cannot be analyzed by Vite.
See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning.

  Plugin: vite:import-analysis
  File: C:/Users/Ric/Projects/orbulis-portal/.angular/cache/19.1.4/orbulis-portal/vite/deps/ng2-pdf-viewer.js?v=2ae645d4

[zhan2016]

Any updates?

[rcrafael]

I made it working now. try this in your package.json.

• angular version: 19.0.3
• ng2-pdf-viewer version : 10.2.2

1. set all angular package to ^19.0.3 (in my case i use this version)
2. set the following version for your angular dev/dependencies in your package.json (see items below)
3. delete .angular and node_modules folder
4. delete package-lock.json
5. run npm install
6. ng server

"devDependencies": {
"@angular-devkit/build-angular": "^19.0.2",
"@angular/cli": "^19.0.2",
"@angular/compiler-cli": "^19.0.0",
"@types/jasmine": "~5.1.0",
"jasmine-core": "~5.4.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.2.0",
"karma-coverage": "~2.2.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.1.0",
"typescript": "~5.6.2"
}

[fua03]

The issue was resolved in the newest version of pdfjs-dist (released 2 days ago). I created the following PR to update the version of the aforementioned lib in ng2-pdf-viewer:#1188

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[samuelmoser]

still a problem