1.20.4 - Thirst saving with bigger amount of playerdata causes significant lag

[jan-osicka]

❗ Checklist

• I am using the official version of Realistic Survival and did not modify the jar.
• I am using an up-to-date "dev-build" (not "Spigot") version of Realistic Survival.
• I know that issues related to other plugins need to be reported on their bug trackers and not here.
• I searched for similar open issues and could not find an existing bug report on this.

📍 Description

When server actually uses this plugin it causes on versions 1.20.4 and 1.20.6 (these are tested, paper and purpur) the plugin is lagging the server due to saving of Thirst of players. Attaching log and also my player data from test server.

RSLag.log
playerdata.zip

📑 Reproduction Steps

1. Install new server with latest dev build.
2. Generate at least 200 unique players (or 2000 for TPS drop to single digits)
3. Wait for Thirst to save and update
4. Watch on Spark RSV consuming all the resources trying to save the data (tested on VPS, shared host and local pc)

💡 Expected Behavior

I expected better saving of players data. At least save it async not in the main thread

📷 Screenshots / Videos

No response

📜 Server Log

No response

💻 Server Software

Purpur

🎮 Minecraft Version

1.20.x

⭐ Realistic Survival version

latest

🧭 Other plugins

none