refactored code

Author: ValentinGurkov

Combat/Projectile.cs

@@ -127,19 +127,16 @@ private IEnumerator ReturnToPoolWithDelay(float delay) {
         /// <param name="instigator"></param>
         /// <param name="damage"></param>
         /// <param name="updateUI"></param>
-        public void SetTarget(Health target, GameObject instigator, float damage, Action updateUI) {
+        public void SetTarget(Health target, GameObject instigator, float damage, Action updateUI, string tag) {
             this.target = target;
             this.damage = damage;
             this.instigator = instigator;
             this.updateUI = updateUI;
             speed = originalSpeed;
-            PointTowardsTarget();
-        }
-
-        public void SetPoolTag(string tag) {
             if (string.IsNullOrEmpty(poolTag)) {
                 poolTag = tag;
             }
+            PointTowardsTarget();
         }
     }
 }

Combat/WeaponConfig.cs

@@ -85,8 +85,7 @@ public void LaunchProjectile(Transform rightHand, Transform leftHand, Health tar
             Projectile projectileInstance = instance.GetComponent<Projectile>();
             projectileInstance.transform.position = GetTransform(rightHand, leftHand).position;
             projectile.transform.rotation = Quaternion.identity;
-            projectileInstance.SetTarget(target, instigator, calculatedDamage, updateUI);
-            projectileInstance.SetPoolTag(projectileTag);
+            projectileInstance.SetTarget(target, instigator, calculatedDamage, updateUI, projectileTag);
         }
     }
 }

Util/ObjectPooler.cs

@@ -23,6 +23,19 @@ private void Awake() {
             FillPools();
         }
 
+        private void FillPool(string tag) {
+            if (!poolDict.ContainsKey(tag)) {
+                return;
+            }
+            Pool pool = pools.Find(p => p.tag == tag);
+            for (int j = 0; j < pool.size; j++) {
+                GameObject obj = Instantiate(pool.prefab);
+                obj.transform.SetParent(transform);
+                obj.SetActive(false);
+                poolDict[tag].Enqueue(obj);
+            }
+        }
+
         private void FillPools() {
             for (int i = 0; i < pools.Count; i++) {
                 Queue<GameObject> objectPool = new Queue<GameObject>();
@@ -36,19 +49,6 @@ private void FillPools() {
             }
         }
 
-        public void FillPool(string tag) {
-            if (!poolDict.ContainsKey(tag)) {
-                return;
-            }
-            Pool pool = pools.Find(p => p.tag == tag);
-            for (int j = 0; j < pool.size; j++) {
-                GameObject obj = Instantiate(pool.prefab);
-                obj.transform.SetParent(transform);
-                obj.SetActive(false);
-                poolDict[tag].Enqueue(obj);
-            }
-        }
-
         public void AddToPool(string tag, GameObject instance) {
             if (!poolDict.ContainsKey(tag)) {
                 return;