Only variables should be assigned by reference

Author: valzargaming

src/VerifierServer/Endpoints/SS14VerifiedEndpoint.php

@@ -155,7 +155,7 @@ protected function __post(array &$list, string $ss14, string $discord, int|strin
 
     public function add(string $discord, string $ss14): void
     {
-        $list = &$this->state->getVerifyList();
+        $list = $this->state->getVerifyList();
         $list[] = [
             'discord' => $discord,
             'ss14' => $ss14,
@@ -174,7 +174,7 @@ public function remove(string $discord, string $ss14 = ''): ?array
 
     public function getIndex(string $discord, string $ss14 = ''): int|string|false
     {
-        $list = &$this->state->getVerifyList();
+        $list = $this->state->getVerifyList();
         $existingIndex = array_search($discord, array_column($list, 'discord'));
         if ($ss14 && $existingIndex === false) $existingIndex = array_search($ss14, array_column($list, 'ss14'));
         return $existingIndex;

src/VerifierServer/Endpoints/VerifiedEndpoint.php

@@ -253,7 +253,7 @@ protected function delete(int|string|false $existingIndex, array &$list, int|str
 
     public function add(string $discord, string $ckey): void
     {
-        $list = &$this->state->getVerifyList();
+        $list = $this->state->getVerifyList();
         $list[] = [
             'discord' => $discord,
             'ss13' => $ckey,
@@ -272,15 +272,15 @@ public function remove(string $discord, string $ckey = ''): ?array
 
     public function getIndex(string $discord, string $ckey = ''): int|string|false
     {
-        $list = &$this->state->getVerifyList();
+        $list = $this->state->getVerifyList();
         $existingIndex = array_search($ckey, array_column($list, 'ss13'));
         if ($ckey && $existingIndex === false) $existingIndex = array_search($discord, array_column($list, 'discord'));
         return $existingIndex;
     }
 
     public function removeIndex(int|string $existingIndex): array
     {
-        $list = &$this->state->getVerifyList();
+        $list = $this->state->getVerifyList();
         $splice = array_splice($list, (int)$existingIndex, 1);
         $this->state::writeJson($this->state->getJsonPath(), $list);
         $this->state->setVerifyList($list);