Skip to content

Firerate Card showing incorrect value when near minimum value #4

@valkyrienyanko

Description

@valkyrienyanko

Untitled

Notice how it shows -40. It should be 10, not -40. This is because of Firerate = Mathf.Max(Firerate, 10); in

// Player.cs
public void IncreaseFirerate(int removeMs)
{
    Firerate -= removeMs;
    Firerate = Mathf.Max(Firerate, 10);

    timerLasers.Start(Firerate);
}

But UICard.cs does not account for this.

// UICard.cs
case CardUpgradeType.Firerate:
    cardUpgradeNote.SetInfo(
        type: CardUpgradeType,
        before: player.Firerate,
        after: player.Firerate - 50);
    break;

Just does player.Firerate - 50.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions