Skip to content

Defining upgrade increments in script twice #5

@valkyrienyanko

Description

@valkyrienyanko

Notice how in the code below I have to define for example 10 for speed in one place and 10 for speed in another place. Defining the upgrade increment in one place for speed (and all other upgrades) would be much nicer.

// UICard.cs
OnPicked += () =>
{
    switch (CardUpgradeType)
    {
        case CardUpgradeType.Speed:
            player.Speed += 10;
            break;
        case CardUpgradeType.Health:
            player.AddHealth(5);
            break;
        case CardUpgradeType.MaxHealth:
            player.AddMaxHealth(5);
            break;
        case CardUpgradeType.Firerate:
            player.IncreaseFirerate(50);
            break;
    }
};

CardTitle.Text = CardUpgradeType + "";

var cardUpgradeNote = (UICardUpgradeNote)Prefabs.CardUpgradeNote.Instantiate();

switch (CardUpgradeType)
{
    case CardUpgradeType.Speed:
        cardUpgradeNote.SetInfo(
            type: CardUpgradeType,
            before: player.Speed,
            after: player.Speed + 10);
        break;
    case CardUpgradeType.Health:
        cardUpgradeNote.SetInfo(
            type: CardUpgradeType,
            before: player.Health,
            after: player.Health + 5);
        break;
    case CardUpgradeType.MaxHealth:
        cardUpgradeNote.SetInfo(
            type: CardUpgradeType,
            before: player.MaxHealth,
            after: player.MaxHealth + 5);
        break;
    case CardUpgradeType.Firerate:
        cardUpgradeNote.SetInfo(
            type: CardUpgradeType,
            before: player.Firerate,
            after: player.Firerate - 50);
        break;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions