Inappropriately named logger

[rwilliaise]

Currently, the logger for the Kelvin mod is called Meringue Factory.

Kelvin/common/src/main/kotlin/org/valkyrienskies/kelvin/KelvinMod.kt

Line 38 in cdec8ef

val KELVINLOGGER = logger("Meringue Factory").logger

This is particularly confusing when combing through logs that look like this:

...

[11:31:01] [Render thread/WARN] [Meringue Factory/]: Client does not have access to this information. [getNodeAt]

...

[blockninja124]

• VS Connectivity is labelled as "5G cell tower"
• VS networking server-side is called "Woman Eater"
• Networking client-side is called "Man eater"
• The VS physics pipeline is "Burger factory"
• The VS drag controller is "Pizza factory"
• The dimension parameters resolver is "bloon factory",
• The ship assembler is "Sandwhich factory"
• The ship splitting handler is "kit-kat factory"
• The phys level is "Pie factory"

All of these are just us devs having some fun with our loggers, especially since we're the ones that are usually sifting through logs. I can see how this might be a little irritating for modpack developers debugging on their own, but its better than no logs at all and I feel the logs still make sense based on context and content.

[CallumCM]

That totally makes sense, and I think it's quite reasonable to have something like silly logger named for different parts of a mod. For me, I was also running into the problem where my log was being spammed with Client does not have access to this information. from MeringueFactory, and I had to unzip all my mods and run a binary search to see which mod was doing that.

I imagine a problem like that isn't super common, but I wonder if the loggers could be prefixed with something like ValkyrinSkies/Kit-Kat Factory to make the origin of the log more clear to modpack devs (and still keep some joy and whimsy in the mod's code).

[blockninja124]

That could work, maybe when someone gets round to changing them all.