Skip to content

Commit 29e1fba

Browse files
hazeonehazeone
authored
refactor(frontend): comment out unused routes (#593)
## 📝 Pull Request Template Revert this commit in the future. ### 2. Type of Change (select one) Type of Change: Code Refactor ### 3. Description Please describe the changes made and why they are necessary. ### 4. Testing - [x] I have tested this locally. - [x] I have updated or added relevant tests. ### 5. Checklist - [x] I have read the [Code of Conduct](./CODE_OF_CONDUCT.md) - [x] I have followed the [Contributing Guidelines](./CONTRIBUTING.md) - [x] My changes follow the project's coding style
1 parent 366a3f9 commit 29e1fba

File tree

4 files changed

+55
-64
lines changed

4 files changed

+55
-64
lines changed

‎frontend/src/app/agent/components/strategy-items/portfolio-positions-group.tsx‎

Lines changed: 41 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,10 @@
11
import { LineChart, Wallet } from "lucide-react";
2-
import { type FC, memo, useRef } from "react";
2+
import { type FC, memo } from "react";
33
import { useTranslation } from "react-i18next";
4-
import { useStrategyPerformance } from "@/api/strategy";
5-
import { usePublishStrategy } from "@/api/system";
4+
// import { useStrategyPerformance } from "@/api/strategy";
5+
// import { usePublishStrategy } from "@/api/system";
66
import { ValueCellAgentPng } from "@/assets/png";
7-
import { Send, Share } from "@/assets/svg";
87
import { Badge } from "@/components/ui/badge";
9-
import { Button } from "@/components/ui/button";
10-
import {
11-
DropdownMenu,
12-
DropdownMenuContent,
13-
DropdownMenuItem,
14-
DropdownMenuTrigger,
15-
} from "@/components/ui/dropdown-menu";
16-
import { Spinner } from "@/components/ui/spinner";
178
import {
189
Table,
1910
TableBody,
@@ -24,20 +15,19 @@ import {
2415
} from "@/components/ui/table";
2516
import MultiLineChart from "@/components/valuecell/charts/model-multi-line";
2617
import { PngIcon } from "@/components/valuecell/icon/png-icon";
27-
import SvgIcon from "@/components/valuecell/icon/svg-icon";
28-
import LoginModal from "@/components/valuecell/modal/login-modal";
29-
import { useTauriInfo } from "@/hooks/use-tauri-info";
18+
// import { useTauriInfo } from "@/hooks/use-tauri-info";
3019
import {
3120
formatChange,
3221
getChangeType,
3322
getCoinCapIcon,
3423
numberFixed,
3524
} from "@/lib/utils";
3625
import { useStockColors } from "@/store/settings-store";
37-
import { useIsLoggedIn, useSystemInfo } from "@/store/system-store";
26+
// import { useIsLoggedIn, useSystemInfo } from "@/store/system-store";
3827
import type { PortfolioSummary, Position, Strategy } from "@/types/strategy";
39-
import type { SharePortfolioCardRef } from "./modals/share-portfolio-modal";
40-
import SharePortfolioModal from "./modals/share-portfolio-modal";
28+
29+
// import type { SharePortfolioCardRef } from "./modals/share-portfolio-modal";
30+
// import SharePortfolioModal from "./modals/share-portfolio-modal";
4131

4232
interface PortfolioPositionsGroupProps {
4333
priceCurve: Array<Array<number | string>>;
@@ -104,50 +94,50 @@ const PortfolioPositionsGroup: FC<PortfolioPositionsGroupProps> = ({
10494
summary,
10595
priceCurve,
10696
positions,
107-
strategy,
97+
// strategy,
10898
}) => {
10999
const { t } = useTranslation();
110-
const sharePortfolioModalRef = useRef<SharePortfolioCardRef>(null);
100+
// const sharePortfolioModalRef = useRef<SharePortfolioCardRef>(null);
111101

112102
const stockColors = useStockColors();
113103
const changeType = getChangeType(summary?.total_pnl);
114-
const { name, avatar } = useSystemInfo();
115-
const isLogin = useIsLoggedIn();
116-
const { isTauriApp } = useTauriInfo();
104+
// const { name, avatar } = useSystemInfo();
105+
// const isLogin = useIsLoggedIn();
106+
// const { isTauriApp } = useTauriInfo();
117107

118108
const hasPositions = positions.length > 0;
119109
const hasPriceCurve = priceCurve.length > 0;
120110

121-
const { mutate: publishStrategy, isPending: isPublishing } =
122-
usePublishStrategy();
111+
// const { mutate: publishStrategy, isPending: isPublishing } =
112+
// usePublishStrategy();
123113

124-
const { refetch: refetchPerformance } = useStrategyPerformance(
125-
strategy.strategy_id,
126-
);
114+
// const { refetch: refetchPerformance } = useStrategyPerformance(
115+
// strategy.strategy_id,
116+
// );
127117

128-
const handlePublishToRankBoard = async () => {
129-
const { data } = await refetchPerformance();
130-
if (!data) return;
131-
const { exchange_id, ...rest } = data;
118+
// const handlePublishToRankBoard = async () => {
119+
// const { data } = await refetchPerformance();
120+
// if (!data) return;
121+
// const { exchange_id, ...rest } = data;
132122

133-
publishStrategy({
134-
...rest,
135-
exchange_id: exchange_id || "virtual",
136-
name,
137-
avatar,
138-
});
139-
};
123+
// publishStrategy({
124+
// ...rest,
125+
// exchange_id: exchange_id || "virtual",
126+
// name,
127+
// avatar,
128+
// });
129+
// };
140130

141-
const handleSharePortfolio = async () => {
142-
const { data } = await refetchPerformance();
143-
if (!data) return;
131+
// const handleSharePortfolio = async () => {
132+
// const { data } = await refetchPerformance();
133+
// if (!data) return;
144134

145-
sharePortfolioModalRef.current?.open({
146-
...data,
147-
total_pnl: summary?.total_pnl ?? 0,
148-
created_at: strategy.created_at,
149-
});
150-
};
135+
// sharePortfolioModalRef.current?.open({
136+
// ...data,
137+
// total_pnl: summary?.total_pnl ?? 0,
138+
// created_at: strategy.created_at,
139+
// });
140+
// };
151141

152142
return (
153143
<div className="scroll-container flex flex-1 flex-col gap-8 p-6">
@@ -157,6 +147,7 @@ const PortfolioPositionsGroup: FC<PortfolioPositionsGroupProps> = ({
157147
<h3 className="font-semibold text-base text-foreground">
158148
{t("strategy.portfolio.title")}
159149
</h3>
150+
{/* Publish/Share features - commented out (requires login)
160151
{isTauriApp &&
161152
(isLogin ? (
162153
<DropdownMenu>
@@ -192,6 +183,7 @@ const PortfolioPositionsGroup: FC<PortfolioPositionsGroupProps> = ({
192183
</Button>
193184
</LoginModal>
194185
))}
186+
*/}
195187
</div>
196188

197189
<div className="grid grid-cols-3 gap-4 text-nowrap">
@@ -311,7 +303,7 @@ const PortfolioPositionsGroup: FC<PortfolioPositionsGroupProps> = ({
311303
)}
312304
</div>
313305

314-
<SharePortfolioModal ref={sharePortfolioModalRef} />
306+
{/* <SharePortfolioModal ref={sharePortfolioModalRef} /> */}
315307
</div>
316308
);
317309
};

‎frontend/src/app/setting/general.tsx‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { useTheme } from "next-themes";
22
import { useTranslation } from "react-i18next";
3-
import { useSignOut } from "@/api/system";
3+
// import { useSignOut } from "@/api/system";
44
import { Badge } from "@/components/ui/badge";
55
import { Button } from "@/components/ui/button";
66
import {
@@ -19,17 +19,15 @@ import {
1919
SelectTrigger,
2020
SelectValue,
2121
} from "@/components/ui/select";
22-
import LoginModal from "@/components/valuecell/modal/login-modal";
2322
import { useTauriInfo } from "@/hooks/use-tauri-info";
2423
import { useUpdateToast } from "@/hooks/use-update-toast";
25-
import { withTrack } from "@/lib/tracker";
2624
import type { LanguageCode, StockColorMode } from "@/store/settings-store";
2725
import {
2826
useLanguage,
2927
useSettingsActions,
3028
useStockColorMode,
3129
} from "@/store/settings-store";
32-
import { useIsLoggedIn, useSystemInfo } from "@/store/system-store";
30+
// import { useIsLoggedIn, useSystemInfo } from "@/store/system-store";
3331

3432
export default function GeneralPage() {
3533
const { t } = useTranslation();
@@ -39,10 +37,10 @@ export default function GeneralPage() {
3937
const { setStockColorMode, setLanguage } = useSettingsActions();
4038
const { checkAndUpdate } = useUpdateToast();
4139
const { isTauriApp, appVersion } = useTauriInfo();
42-
const { email, id } = useSystemInfo();
43-
const isLoggedIn = useIsLoggedIn();
40+
// const { email, id } = useSystemInfo();
41+
// const isLoggedIn = useIsLoggedIn();
4442

45-
const { mutate: signOut } = useSignOut();
43+
// const { mutate: signOut } = useSignOut();
4644
return (
4745
<div className="flex flex-1 flex-col gap-4 p-10">
4846
<div className="flex flex-col gap-1.5">
@@ -53,6 +51,7 @@ export default function GeneralPage() {
5351
</div>
5452

5553
<FieldGroup className="gap-6">
54+
{/* Account section - commented out for now
5655
{isTauriApp && (
5756
<Field orientation="horizontal">
5857
<FieldContent>
@@ -78,6 +77,7 @@ export default function GeneralPage() {
7877
)}
7978
</Field>
8079
)}
80+
*/}
8181

8282
<Field orientation="horizontal">
8383
<FieldContent>

‎frontend/src/components/valuecell/app/app-sidebar.tsx‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {
1212
Conversation,
1313
Logo,
1414
Market,
15-
Ranking,
1615
Setting,
1716
StrategyAgent,
1817
} from "@/assets/svg";
@@ -155,12 +154,12 @@ const AppSidebar: FC = () => {
155154
label: t("nav.strategy"),
156155
to: "/agent/StrategyAgent",
157156
},
158-
{
159-
id: "ranking",
160-
icon: Ranking,
161-
label: t("nav.ranking"),
162-
to: "/ranking",
163-
},
157+
// {
158+
// id: "ranking",
159+
// icon: Ranking,
160+
// label: t("nav.ranking"),
161+
// to: "/ranking",
162+
// },
164163
{
165164
id: "market",
166165
icon: Market,

‎frontend/src/routes.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export default [
1818

1919
route("/market", "app/market/agents.tsx"),
2020

21-
route("/ranking", "app/rank/board.tsx"),
21+
// route("/ranking", "app/rank/board.tsx"),
2222

2323
...prefix("/agent", [
2424
route("/:agentName", "app/agent/chat.tsx"),

0 commit comments

Comments
 (0)