build!: Always implement calls_made

Removes conditional compilation of
`ElectrumApi::calls_made`. As a result
the `debug-calls` feature flag is also removed.

Author: ValuedMammal

.github/workflows/cont_integration.yml

@@ -36,7 +36,6 @@ jobs:
         run: cargo test -- --ignored test_local_timeout
       - run: cargo check --verbose --features=use-openssl
       - run: cargo check --verbose --no-default-features --features=proxy
-      - run: cargo check --verbose --no-default-features --features=debug-calls
       - run: cargo check --verbose --no-default-features --features=proxy,use-openssl
       - run: cargo check --verbose --no-default-features --features=proxy,use-rustls
       - run: cargo check --verbose --no-default-features --features=proxy,use-rustls-ring

Cargo.toml

@@ -39,7 +39,6 @@ winapi = { version="0.3.9", features=["winsock2"], optional = true }
 
 [features]
 default = ["proxy", "rustls"]
-debug-calls = []
 proxy = ["byteorder", "winapi", "libc"]
 rustls = ["webpki-roots", "dep:rustls", "rustls/default"]
 rustls-ring = ["webpki-roots", "dep:rustls", "rustls/ring", "rustls/logging", "rustls/std", "rustls/tls12"]

src/api.rs

@@ -176,7 +176,6 @@ where
         (**self).ping()
     }
 
-    #[cfg(feature = "debug-calls")]
     fn calls_made(&self) -> Result<usize, Error> {
         (**self).calls_made()
     }
@@ -402,7 +401,6 @@ pub trait ElectrumApi {
     /// of incoming block header or script notifications.
     fn ping(&self) -> Result<(), Error>;
 
-    #[cfg(feature = "debug-calls")]
     /// Returns the number of network calls made since the creation of the client.
     fn calls_made(&self) -> Result<usize, Error>;
 }
@@ -611,7 +609,6 @@ mod test {
             unreachable!()
         }
 
-        #[cfg(feature = "debug-calls")]
         fn calls_made(&self) -> Result<usize, super::Error> {
             unreachable!()
         }

src/client.rs

@@ -380,7 +380,6 @@ impl ElectrumApi for Client {
     }
 
     #[inline]
-    #[cfg(feature = "debug-calls")]
     fn calls_made(&self) -> Result<usize, Error> {
         impl_inner_call!(self, calls_made)
     }

src/raw_client.rs

@@ -136,7 +136,6 @@ where
     headers: Mutex<VecDeque<RawHeaderNotification>>,
     script_notifications: Mutex<HashMap<ScriptHash, VecDeque<ScriptStatus>>>,
 
-    #[cfg(feature = "debug-calls")]
     calls: AtomicUsize,
 }
 
@@ -157,7 +156,6 @@ where
             headers: Mutex::new(VecDeque::new()),
             script_notifications: Mutex::new(HashMap::new()),
 
-            #[cfg(feature = "debug-calls")]
             calls: AtomicUsize::new(0),
         }
     }
@@ -741,14 +739,9 @@ impl<S: Read + Write> RawClient<S> {
     }
 
     #[inline]
-    #[cfg(feature = "debug-calls")]
     fn increment_calls(&self) {
         self.calls.fetch_add(1, Ordering::SeqCst);
     }
-
-    #[inline]
-    #[cfg(not(feature = "debug-calls"))]
-    fn increment_calls(&self) {}
 }
 
 impl<T: Read + Write> ElectrumApi for RawClient<T> {
@@ -1169,7 +1162,6 @@ impl<T: Read + Write> ElectrumApi for RawClient<T> {
         Ok(())
     }
 
-    #[cfg(feature = "debug-calls")]
     fn calls_made(&self) -> Result<usize, Error> {
         Ok(self.calls.load(Ordering::SeqCst))
     }