Test that we serialize to kv1 without flags and arrays

Author: xPaw

ValveKeyValue/ValveKeyValue.Test/Test Data/TextKV3/array.kv3

@@ -23,6 +23,11 @@
 		#[
 			11 FF
 		],
-		resource:"hello.world"
+		resource:"hello.world",
+		"""
+multiline
+string
+""",
+		-69.420
 	]
 }

ValveKeyValue/ValveKeyValue.Test/Test Data/TextKV3/array_kv1.vdf

@@ -0,0 +1,43 @@
+"root"
+{
+	"arrayValue"
+	{
+		"0"	"a"
+		"1"	"b"
+	}
+	"arrayOnSingleLine"
+	{
+		"0"	"16.7551"
+		"1"	"20.3763"
+		"2"	"19.6448"
+	}
+	"arrayNoSpace"
+	{
+		"0"	"1.3763"
+		"1"	"19.6448"
+	}
+	"arrayMixedTypes"
+	{
+		"0"	"a"
+		"1"	"1"
+		"2"	"True"
+		"3"	"False"
+		"4"	""
+		"5"
+		{
+			"foo"	"bar"
+		}
+		"6"
+		{
+			"0"	"1"
+			"1"	"3"
+			"2"	"3"
+			"3"	"7"
+		}
+		"7"	"hello.world"
+		"8"	"multiline
+string"
+		"9"	"-69.42"
+	}
+	"test"	"success"
+}

ValveKeyValue/ValveKeyValue.Test/Test Data/TextKV3/flagged_value_kv1.vdf

@@ -0,0 +1,21 @@
+"root"
+{
+	"foo"	"bar"
+	"bar"	"foo"
+	"uppercase"	"foo"
+	"flaggedNumber"	"-1234"
+	"multipleFlags"	"cool value"
+	"soundEvent"	"event sound"
+	"noFlags"	"5"
+	"flaggedObject"
+	{
+		"1"	"test1"
+		"2"	"test2"
+		"3"
+		{
+			"0"	"test3"
+		}
+		"4"	"test4"
+	}
+	"test"	"success"
+}

ValveKeyValue/ValveKeyValue.Test/TextKV3/Kv3ToKv1TestCase.cs

@@ -0,0 +1,60 @@
+using System.IO;
+using NUnit.Framework;
+
+namespace ValveKeyValue.Test.TextKV3
+{
+    class Kv3ToKv1TestCase
+    {
+        [Test]
+        public void SerializesAndDropsFlags()
+        {
+            using var stream = TestDataHelper.OpenResource("TextKV3.flagged_value.kv3");
+            var expected = TestDataHelper.ReadTextResource("TextKV3.flagged_value_kv1.vdf");
+
+            var kv1 = KVSerializer.Create(KVSerializationFormat.KeyValues1Text);
+            var kv3 = KVSerializer.Create(KVSerializationFormat.KeyValues3Text);
+            var data = kv3.Deserialize(stream);
+
+            data.Add(new KVObject("test", "success"));
+
+            string text;
+            using (var ms = new MemoryStream())
+            {
+                kv1.Serialize(ms, data);
+
+                ms.Seek(0, SeekOrigin.Begin);
+                using var reader = new StreamReader(ms);
+                text = reader.ReadToEnd();
+            }
+
+            Assert.That(text, Is.EqualTo(expected));
+        }
+
+        [Test]
+        public void SerializesArraysToObjects()
+        {
+            using var stream = TestDataHelper.OpenResource("TextKV3.array.kv3");
+            var expected = TestDataHelper.ReadTextResource("TextKV3.array_kv1.vdf");
+
+            var kv1 = KVSerializer.Create(KVSerializationFormat.KeyValues1Text);
+            var kv3 = KVSerializer.Create(KVSerializationFormat.KeyValues3Text);
+            var data = kv3.Deserialize(stream);
+
+            data.Add(new KVObject("test", "success"));
+
+            string text;
+            using (var ms = new MemoryStream())
+            {
+                kv1.Serialize(ms, data);
+
+                ms.Seek(0, SeekOrigin.Begin);
+                using var reader = new StreamReader(ms);
+                text = reader.ReadToEnd();
+            }
+
+            System.Console.WriteLine(text);
+
+            Assert.That(text, Is.EqualTo(expected));
+        }
+    }
+}

ValveKeyValue/ValveKeyValue/Serialization/KeyValues1/KV1TextSerializer.cs

@@ -1,7 +1,9 @@
 using System;
+using System.Collections.Generic;
 using System.Globalization;
 using System.IO;
 using System.Text;
+using System.Xml.Linq;
 using ValveKeyValue.Abstraction;
 
 namespace ValveKeyValue.Serialization.KeyValues1
@@ -23,6 +25,7 @@ public KV1TextSerializer(Stream stream, KVSerializerOptions options)
         readonly KVSerializerOptions options;
         readonly TextWriter writer;
         int indentation = 0;
+        Stack<int> arrayCount = new();
 
         public void Dispose()
         {
@@ -38,9 +41,26 @@ public void OnObjectEnd()
         public void OnKeyValuePair(string name, KVValue value)
             => WriteKeyValuePair(name, value);
 
-        public void OnArrayStart(string name, KVFlag flag) => throw new NotImplementedException();
-        public void OnArrayValue(KVValue value) => throw new NotImplementedException();
-        public void OnArrayEnd() => throw new NotImplementedException();
+        public void OnArrayStart(string name, KVFlag flag)
+        {
+            WriteStartObject(name);
+            arrayCount.Push(0);
+        }
+
+        public void OnArrayValue(KVValue value)
+        {
+            var count = arrayCount.Pop();
+
+            WriteKeyValuePair(count.ToString(), value);
+
+            arrayCount.Push(count + 1);
+        }
+
+        public void OnArrayEnd()
+        {
+            WriteEndObject();
+            arrayCount.Pop();
+        }
 
         public void DiscardCurrentObject()
         {
@@ -49,6 +69,15 @@ public void DiscardCurrentObject()
 
         void WriteStartObject(string name)
         {
+            if (name == null)
+            {
+                var count = arrayCount.Pop();
+
+                name = count.ToString();
+
+                arrayCount.Push(count + 1);
+            }
+
             WriteIndentation();
             WriteText(name);
             WriteLine();
@@ -68,6 +97,8 @@ void WriteEndObject()
 
         void WriteKeyValuePair(string name, IConvertible value)
         {
+            // TODO: Handle true, false, null value types
+
             WriteIndentation();
             WriteText(name);
             writer.Write('\t');