[vogleditor] Build failure with Qt 5.5

[imirkin]

I'm seeing the following build failures. I have Qt 5.5.0 installed:

In file included from .../src/vogleditor/vogleditor_qsettings.cpp:1:0:
.../src/vogleditor/vogleditor_qsettings.h:50:1: error: expected class-name before '{' token
 {
 ^
.../src/vogleditor/vogleditor_qsettings.h:51:5: error: 'Q_OBJECT' does not name a type
     Q_OBJECT
     ^
.../src/vogleditor/vogleditor_qsettings.h:65:1: error: 'signals' does not name a type
 signals:
 ^
.../src/vogleditor/vogleditor_qsettings.h: In member function 'void vogleditor_qsettings::update_group_active_lists()':
.../src/vogleditor/vogleditor_qsettings.h:259:9: error: 'emit' was not declared in this scope
         emit treeDisplayChanged();
         ^
.../src/vogleditor/vogleditor_qsettings.h:259:14: error: expected ';' before 'treeDisplayChanged'
         emit treeDisplayChanged();
              ^

.../src/vogleditor/vogleditor_qsettings.cpp: At global scope:
.../src/vogleditor/vogleditor_qsettings.cpp:13:44: error: definition of implicitly-declared 'vogleditor_qsettings::vogleditor_qsettings()'
 vogleditor_qsettings::vogleditor_qsettings()
                                            ^
.../src/vogleditor/vogleditor_qsettings.cpp:1:0:
.../src/vogleditor/vogleditor_qsettings.h: In function 'void __static_initialization_and_destruction_0(int, int)':
.../src/vogleditor/vogleditor_qsettings.h:55:13: error: 'virtual vogleditor_qsettings::~vogleditor_qsettings()' is private
     virtual ~vogleditor_qsettings()
             ^

[karolherbst]

seems to be like this issue: QupZilla/qupzilla#970

[imirkin]

Looks like the following patch fixes the problem.

diff --git a/src/vogleditor/vogleditor_qsettings.h b/src/vogleditor/vogleditor_qsettings.h
index 215d495..db8c171 100644
--- a/src/vogleditor/vogleditor_qsettings.h
+++ b/src/vogleditor/vogleditor_qsettings.h
@@ -3,6 +3,7 @@

 #include "vogl_dynamic_string.h"
 #include "vogl_json.h"
+#include <QObject>
 #include <QStringList>
 #include <QVector>

Courtesy of @karolherbst

[kankaristo]

Thanks @imirkin, fixed the build for me. 👍

Same issue here, seems to not be fixed

The missing include fixed it, thanks @kingtaurus

[AzP]

Any chance someone will merge the pull request that fixes this? It's a shame that development seems to have stopped completely since several people still has use of this tool.

[perkele1989]

^ volvo plz

[Plagman]

I merged the pull request, but we don't have a maintainer for vogl anymore and it can be considered deprecated unless someone wants to take ownership of it.

[karolherbst]

@Plagman and is there anything new to use or just good ol' apitrace?

[AzP]

@karolherbst My impression from discussions at GDC is that RenderDoc has more or less replaced VoGL since it supports both OpenGL (only forward-compatible contexts) and Vulkan. But I'm also interested in a more concrete answer from @Plagman and Valve's view on it.

[Plagman]

RenderDoc is what we'll be focusing on; mainly from a Vulkan perspective, but it should also work for OpenGL. Not clear when the new Qt UI will be fully up to speed to let it be hosted on Linux, but my understanding is that it's being worked on.