Use Spock utilities to test asynchronous code

Author: Vampire

src/test/groovy/net/kautler/command/api/CommandHandlerTest.groovy

@@ -31,6 +31,7 @@ import org.junit.Rule
 import org.powermock.reflect.Whitebox
 import spock.lang.Specification
 import spock.lang.Subject
+import spock.util.concurrent.BlockingVariable
 import spock.util.mop.Use
 
 import javax.annotation.PostConstruct
@@ -40,12 +41,10 @@ import javax.enterprise.inject.Instance
 import javax.enterprise.util.TypeLiteral
 import javax.inject.Inject
 import java.util.Map.Entry
-import java.util.concurrent.CompletableFuture
 import java.util.concurrent.ExecutorService
 
 import static java.lang.Thread.currentThread
 import static java.util.concurrent.TimeUnit.DAYS
-import static java.util.concurrent.TimeUnit.SECONDS
 import static org.apache.logging.log4j.Level.DEBUG
 import static org.apache.logging.log4j.Level.ERROR
 import static org.apache.logging.log4j.Level.INFO
@@ -966,15 +965,15 @@ class CommandHandlerTest extends Specification {
 
     def 'asynchronous command execution should happen asynchronously'() {
         given:
-            def threadFuture = new CompletableFuture()
+            def executingThread = new BlockingVariable<Thread>(5)
 
         when:
             commandHandler.executeAsync(_) {
-                threadFuture.complete(currentThread())
+                executingThread.set(currentThread())
             }
 
         then:
-            threadFuture.get(5, SECONDS) != currentThread()
+            executingThread.get() != currentThread()
     }
 
     @Use([ContextualInstanceCategory,  Whitebox])

src/test/groovy/net/kautler/command/handler/CommandHandlerJavacordTest.groovy

@@ -38,6 +38,7 @@ import org.jboss.weld.junit4.WeldInitiator
 import org.junit.Rule
 import spock.lang.Specification
 import spock.lang.Subject
+import spock.util.concurrent.BlockingVariable
 import spock.util.mop.Use
 
 import javax.annotation.PostConstruct
@@ -48,14 +49,11 @@ import javax.enterprise.inject.Instance
 import javax.enterprise.util.TypeLiteral
 import javax.inject.Inject
 import java.lang.reflect.Type
-import java.util.concurrent.CompletableFuture
-import java.util.concurrent.CountDownLatch
 import java.util.concurrent.ExecutorService
 
 import static java.lang.Thread.currentThread
 import static java.util.Arrays.asList
 import static java.util.concurrent.TimeUnit.DAYS
-import static java.util.concurrent.TimeUnit.SECONDS
 import static org.apache.logging.log4j.Level.ERROR
 import static org.apache.logging.log4j.Level.INFO
 import static org.apache.logging.log4j.test.appender.ListAppender.getListAppender
@@ -328,19 +326,19 @@ class CommandHandlerJavacordTest extends Specification {
     def 'command not allowed event should be fired on restricted command'() {
         given:
             message.content >> '!test'
-            def countDownLatch = new CountDownLatch(1)
+            def commandNotAllowedEventFired = new BlockingVariable<Boolean>(5)
 
         when:
             commandHandlerJavacord.ci().handleMessage(messageCreateEvent)
-            countDownLatch.await(5, SECONDS)
+            commandNotAllowedEventFired.get()
 
         then:
             with(testEventReceiverDelegate) {
                 1 * handleCommandNotAllowedEvent {
                     it.message == this.message
                     it.prefix == '!'
                     it.usedAlias == this.command.aliases.first()
-                } >> { countDownLatch.countDown() }
+                } >> { commandNotAllowedEventFired.set(true) }
                 0 * _
             }
     }
@@ -349,19 +347,19 @@ class CommandHandlerJavacordTest extends Specification {
     def 'message with correct prefix but wrong trigger should fire command not found event'() {
         given:
             message.content >> '!nocommand'
-            def countDownLatch = new CountDownLatch(1)
+            def commandNotFoundEventReceived = new BlockingVariable<Boolean>(5)
 
         when:
             commandHandlerJavacord.ci().handleMessage(messageCreateEvent)
-            countDownLatch.await(5, SECONDS)
+            commandNotFoundEventReceived.get()
 
         then:
             with(testEventReceiverDelegate) {
                 1 * handleCommandNotFoundEvent {
                     it.message == this.message
                     it.prefix == '!'
                     it.usedAlias == 'nocommand'
-                } >> { countDownLatch.countDown() }
+                } >> { commandNotFoundEventReceived.set(true) }
                 0 * _
             }
     }
@@ -384,15 +382,15 @@ class CommandHandlerJavacordTest extends Specification {
         given:
             def discordApi = new DiscordApiImpl(null, null, null, null, null, false)
             message.api >> discordApi
-            def threadFuture = new CompletableFuture()
+            def executingThread = new BlockingVariable<Thread>(5)
 
         when:
             commandHandlerJavacord.executeAsync(message) {
-                threadFuture.complete(currentThread())
+                executingThread.set(currentThread())
             }
 
         then:
-            threadFuture.get(5, SECONDS) != currentThread()
+            executingThread.get() != currentThread()
 
         cleanup:
             discordApi?.disconnect()

src/test/groovy/net/kautler/command/handler/CommandHandlerJdaTest.groovy

@@ -36,6 +36,7 @@ import org.jboss.weld.junit4.WeldInitiator
 import org.junit.Rule
 import spock.lang.Specification
 import spock.lang.Subject
+import spock.util.concurrent.BlockingVariable
 import spock.util.mop.Use
 
 import javax.annotation.PostConstruct
@@ -46,10 +47,8 @@ import javax.enterprise.inject.Instance
 import javax.enterprise.util.TypeLiteral
 import javax.inject.Inject
 import java.lang.reflect.Type
-import java.util.concurrent.CountDownLatch
 
 import static java.util.Arrays.asList
-import static java.util.concurrent.TimeUnit.SECONDS
 import static org.apache.logging.log4j.Level.INFO
 import static org.apache.logging.log4j.test.appender.ListAppender.getListAppender
 
@@ -357,19 +356,19 @@ class CommandHandlerJdaTest extends Specification {
     def 'command not allowed event should be fired on restricted command'() {
         given:
             message.contentRaw >> '!test'
-            def countDownLatch = new CountDownLatch(1)
+            def commandNotAllowedEventFired = new BlockingVariable<Boolean>(5)
 
         when:
             commandHandlerJda.ci().onEvent(messageReceivedEvent)
-            countDownLatch.await(5, SECONDS)
+            commandNotAllowedEventFired.get()
 
         then:
             with(testEventReceiverDelegate) {
                 1 * handleCommandNotAllowedEvent {
                     it.message == this.message
                     it.prefix == '!'
                     it.usedAlias == this.command.aliases.first()
-                } >> { countDownLatch.countDown() }
+                } >> { commandNotAllowedEventFired.set(true) }
                 0 * _
             }
     }
@@ -378,19 +377,19 @@ class CommandHandlerJdaTest extends Specification {
     def 'message with correct prefix but wrong trigger should fire command not found event'() {
         given:
             message.contentRaw >> '!nocommand'
-            def countDownLatch = new CountDownLatch(1)
+            def commandNotFoundEventReceived = new BlockingVariable<Boolean>(5)
 
         when:
             commandHandlerJda.ci().onEvent(messageReceivedEvent)
-            countDownLatch.await(5, SECONDS)
+            commandNotFoundEventReceived.get()
 
         then:
             with(testEventReceiverDelegate) {
                 1 * handleCommandNotFoundEvent {
                     it.message == this.message
                     it.prefix == '!'
                     it.usedAlias == 'nocommand'
-                } >> { countDownLatch.countDown() }
+                } >> { commandNotFoundEventReceived.set(true) }
                 0 * _
             }
     }