Update Javacord version to 3.4.0

Author: Vampire

buildSrc/src/main/kotlin/net/kautler/versions.gradle.kts

@@ -37,7 +37,7 @@ repositories {
 }
 
 val messageFrameworkVersions by extra(mapOf(
-        "javacord" to listOf("3.1.1"),
+        "javacord" to listOf("3.4.0"),
         "jda" to listOf("4.2.0_214")
 ))
 

config/pmd/pmd.xml

@@ -110,6 +110,11 @@
             <property name="constantPattern" value="[a-z][a-zA-Z0-9]*|[A-Z][A-Z_0-9]*"/>
         </properties>
     </rule>
+    <rule ref="category/java/codestyle.xml/FormalParameterNamingConventions">
+        <properties>
+            <property name="lambdaParameterPattern" value="[a-z][a-zA-Z0-9]*|__+" />
+        </properties>
+    </rule>
     <rule ref="category/java/codestyle.xml/LinguisticNaming">
         <properties>
             <property name="violationSuppressXPath">

examples/simplePingBotJavacord/build.gradle.kts

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019-2020 Björn Kautler
+ * Copyright 2019-2022 Björn Kautler
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -29,7 +29,7 @@ dependencies {
     runtimeOnly("org.jboss.weld.se:weld-se-core:3.1.2.Final") { because("CDI implementation") }
     runtimeOnly("org.jboss:jandex:2.1.1.Final") { because("faster CDI bean scanning") }
 
-    implementation("org.javacord:javacord:3.0.5")
+    implementation("org.javacord:javacord:3.4.0")
     implementation("org.apache.logging.log4j:log4j-api:2.12.1")
 
     runtimeOnly("org.apache.logging.log4j:log4j-core:2.12.1")

src/javacordIntegTest/groovy/net/kautler/command/integ/test/javacord/restriction/EveryoneIntegTest.groovy

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Björn Kautler
+ * Copyright 2019-2022 Björn Kautler
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -82,7 +82,7 @@ class EveryoneIntegTest extends Specification {
             }
 
         when:
-            new WebhookClientBuilder(webhook.id, webhook.token.orElseThrow { new AssertionError() })
+            new WebhookClientBuilder(webhook.id, webhook.token)
                     .setWait(false)
                     .build()
                     .send("!ping $random")

src/javacordIntegTest/groovy/net/kautler/command/integ/test/javacord/restriction/RegularUserJavacordIntegTest.groovy

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Björn Kautler
+ * Copyright 2019-2022 Björn Kautler
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -64,7 +64,7 @@ class RegularUserJavacordIntegTest extends Specification {
                     .join()
 
         when:
-            new WebhookClientBuilder(webhook.id, webhook.token.orElseThrow { new AssertionError() })
+            new WebhookClientBuilder(webhook.id, webhook.token)
                     .setWait(false)
                     .build()
                     .send('!ping')

src/main/java/net/kautler/command/handler/CommandHandlerJavacord.java

@@ -181,7 +181,7 @@ protected void fireCommandNotFoundEvent(CommandContext<Message> commandContext)
     @Override
     protected void executeAsync(CommandContext<Message> commandContext, Runnable commandExecutor) {
         runAsync(commandExecutor, commandContext.getMessage().getApi().getThreadPool().getExecutorService())
-                .whenComplete((nothing, throwable) -> {
+                .whenComplete((__, throwable) -> {
                     if (throwable != null) {
                         logger.error("Exception while executing command asynchronously", throwable);
                     }

src/test/groovy/net/kautler/command/handler/CommandHandlerJavacordTest.groovy

@@ -356,7 +356,7 @@ class CommandHandlerJavacordTest extends Specification {
 
     def 'asynchronous command execution should happen asynchronously'() {
         given:
-            def discordApi = new DiscordApiImpl(null, null, null, null, null, false)
+            def discordApi = new DiscordApiImpl(null, null, null, null, null, null, false)
             message.api >> discordApi
             def executingThread = new BlockingVariable<Thread>(5)
 
@@ -374,7 +374,7 @@ class CommandHandlerJavacordTest extends Specification {
 
     def 'asynchronous command execution should not log an error if none happened'() {
         given:
-            def discordApi = new DiscordApiImpl(null, null, null, null, null, false)
+            def discordApi = new DiscordApiImpl(null, null, null, null, null, null, false)
             message.api >> discordApi
 
         when:
@@ -396,7 +396,7 @@ class CommandHandlerJavacordTest extends Specification {
 
     def 'exception during asynchronous command execution should be logged properly'() {
         given:
-            def discordApi = new DiscordApiImpl(null, null, null, null, null, false)
+            def discordApi = new DiscordApiImpl(null, null, null, null, null, null, false)
             message.api >> discordApi
             def exception = new Exception()