Make all beans proxyable

The beans had private constructors, this makes them unproxyable according
to CDI spec and may cause problems when instantiating them, requiring
special unsafe handling and similar things.

Author: Vampire

config/pmd/pmd.xml

@@ -253,19 +253,7 @@
             </property>
         </properties>
     </rule>
-    <rule ref="category/java/errorprone.xml/MissingStaticMethodInNonInstantiatableClass">
-        <properties>
-            <property name="violationSuppressXPath">
-                <value>
-                    .[
-                        ancestor::TypeDeclaration/Annotation[
-                            typeIsExactly('javax.enterprise.context.ApplicationScoped')
-                                or typeIsExactly('javax.enterprise.context.Dependent')]
-                    ]
-                </value>
-            </property>
-        </properties>
-    </rule>
+    <rule ref="category/java/errorprone.xml/MissingStaticMethodInNonInstantiatableClass"/>
     <rule ref="category/java/errorprone.xml/NullAssignment">
         <properties>
             <property name="violationSuppressXPath">

examples/simplePingBotJavacord/src/main/java/net/kautler/command/example/ping/JavacordProducer.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019-2020 Björn Kautler
+ * Copyright 2019-2022 Björn Kautler
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,7 +27,7 @@
 import javax.inject.Named;
 
 @ApplicationScoped
-public class JavacordProducer {
+class JavacordProducer {
     @Inject
     private Logger logger;
 

examples/simplePingBotJavacord/src/main/java/net/kautler/command/example/ping/LoggerProducer.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Björn Kautler
+ * Copyright 2019-2022 Björn Kautler
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -25,9 +25,6 @@
 
 @ApplicationScoped
 class LoggerProducer {
-    private LoggerProducer() {
-    }
-
     @Produces
     private Logger getLogger(InjectionPoint injectionPoint) {
         return LogManager.getLogger(injectionPoint.getMember().getDeclaringClass());

examples/simplePingBotJavacord/src/main/java/net/kautler/command/example/ping/PingBot.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Björn Kautler
+ * Copyright 2019-2022 Björn Kautler
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,13 +21,14 @@
 import javax.enterprise.inject.se.SeContainerInitializer;
 import javax.inject.Named;
 
+import static java.lang.Boolean.FALSE;
 import static java.lang.Boolean.TRUE;
 
 @ApplicationScoped
 public class PingBot {
     @Produces
     @Named
-    public static String discordToken;
+    private static String discordToken;
 
     public static void main(String[] args) {
         if (args.length != 1) {
@@ -37,6 +38,7 @@ public static void main(String[] args) {
         discordToken = args[0];
         SeContainerInitializer.newInstance()
                 .addProperty("javax.enterprise.inject.scan.implicit", TRUE)
+                .addProperty("org.jboss.weld.construction.relaxed", FALSE)
                 .initialize();
     }
 }

examples/simplePingBotJavacord/src/main/java/net/kautler/command/example/ping/PingCommand.java

@@ -25,7 +25,7 @@
 import javax.inject.Inject;
 
 @ApplicationScoped
-public class PingCommand implements Command<Message> {
+class PingCommand implements Command<Message> {
     @Inject
     private Logger logger;
 

examples/simplePingBotJda/src/main/java/net/kautler/command/example/ping/JdaProducer.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019-2020 Björn Kautler
+ * Copyright 2019-2022 Björn Kautler
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -28,7 +28,7 @@
 import javax.security.auth.login.LoginException;
 
 @ApplicationScoped
-public class JdaProducer {
+class JdaProducer {
     @Inject
     private Logger logger;
 

examples/simplePingBotJda/src/main/java/net/kautler/command/example/ping/LoggerProducer.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Björn Kautler
+ * Copyright 2019-2022 Björn Kautler
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -25,9 +25,6 @@
 
 @ApplicationScoped
 class LoggerProducer {
-    private LoggerProducer() {
-    }
-
     @Produces
     private Logger getLogger(InjectionPoint injectionPoint) {
         return LogManager.getLogger(injectionPoint.getMember().getDeclaringClass());

examples/simplePingBotJda/src/main/java/net/kautler/command/example/ping/PingBot.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Björn Kautler
+ * Copyright 2019-2022 Björn Kautler
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -21,13 +21,14 @@
 import javax.enterprise.inject.se.SeContainerInitializer;
 import javax.inject.Named;
 
+import static java.lang.Boolean.FALSE;
 import static java.lang.Boolean.TRUE;
 
 @ApplicationScoped
 public class PingBot {
     @Produces
     @Named
-    public static String discordToken;
+    private static String discordToken;
 
     public static void main(String[] args) {
         if (args.length != 1) {
@@ -37,6 +38,7 @@ public static void main(String[] args) {
         discordToken = args[0];
         SeContainerInitializer.newInstance()
                 .addProperty("javax.enterprise.inject.scan.implicit", TRUE)
+                .addProperty("org.jboss.weld.construction.relaxed", FALSE)
                 .initialize();
     }
 }

examples/simplePingBotJda/src/main/java/net/kautler/command/example/ping/PingCommand.java

@@ -25,7 +25,7 @@
 import javax.inject.Inject;
 
 @ApplicationScoped
-public class PingCommand implements Command<Message> {
+class PingCommand implements Command<Message> {
     @Inject
     private Logger logger;
 

readme/README_template.md

@@ -129,7 +129,7 @@ instances.
 _**Example:**_
 ```java
 @ApplicationScoped
-public class JavacordProducer {
+class JavacordProducer {
     @Inject
     private Logger logger;
 
@@ -170,7 +170,7 @@ produced `JDA` and / or `ShardManager` instances.
 _**Example:**_
 ```java
 @ApplicationScoped
-public class JdaProducer {
+class JdaProducer {
     @Inject
     private Logger logger;
 
@@ -208,7 +208,7 @@ Create a CDI bean that implements the [`Command`][Command JavaDoc] interface.
 _**Example:**_
 ```java
 @ApplicationScoped
-public class PingCommand implements Command<Message> {
+class PingCommand implements Command<Message> {
     @Override
     public void execute(CommandContext<? extends Message> commandContext) {
         commandContext
@@ -276,16 +276,21 @@ like [`ChannelJavacord`][ChannelJavacord JavaDoc], [`RoleJavacord`][RoleJavacord
 _**Examples:**_
 ```java
 @ApplicationScoped
-public class Vampire extends UserJavacord {
-    private Vampire() {
+class Vampire extends UserJavacord {
+    public Vampire() {
         super(341505207341023233L);
     }
 }
 ```
 
 ```java
 @ApplicationScoped
-public class MyFancyServer extends ServerJavacord {
+class MyFancyServer extends ServerJavacord {
+    // make bean proxyable according to CDI spec
+    public MyFancyServer() {
+        super(-1);
+    }
+
     @Inject
     private MyFancyServer(@Named("myFancyServerId") long myFancyServerId) {
         super(myFancyServerId);
@@ -381,7 +386,7 @@ _**Examples:**_
 ```java
 @ApplicationScoped
 @Usage("<text...>")
-public class PingCommand implements Command<Message> {
+class PingCommand implements Command<Message> {
     @Inject
     private ParameterParser parameterParser;
 
@@ -408,7 +413,7 @@ public class PingCommand implements Command<Message> {
 ```java
 @ApplicationScoped
 @Usage("[<user:userMention>] ['exact']")
-public class DoCommand implements Command<Message> {
+class DoCommand implements Command<Message> {
     @Inject
     @Typed
     private ParameterParser parameterParser;
@@ -450,7 +455,7 @@ _**Examples:**_
 ```java
 @ApplicationScoped
 @ParameterType("strings")
-public class StringsConverter implements ParameterConverter<Object, List<String>> {
+class StringsConverter implements ParameterConverter<Object, List<String>> {
     @Override
     public List<String> convert(String parameter, String type, CommandContext<?> commandContext) {
         return asList(parameter.split(","));
@@ -584,7 +589,7 @@ _**Examples:**_
 ```java
 @ApplicationScoped
 @InPhase(BEFORE_PREFIX_COMPUTATION)
-public class MyPrefixTransformer implements CommandContextTransformer<Message> {
+class MyPrefixTransformer implements CommandContextTransformer<Message> {
     @Override
     public <T extends Message> CommandContext<T> transform(CommandContext<T> commandContext, Phase phase) {
         Optional<Server> server = commandContext.getMessage().getServer();
@@ -602,14 +607,14 @@ public class MyPrefixTransformer implements CommandContextTransformer<Message> {
 ```java
 @ApplicationScoped
 @InPhase(BEFORE_PREFIX_COMPUTATION)
-public class MentionPrefixTransformer extends MentionPrefixTransformerJavacord {
+class MentionPrefixTransformer extends MentionPrefixTransformerJavacord {
 }
 ```
 
 ```java
 @ApplicationScoped
 @InPhase(AFTER_ALIAS_AND_PARAMETER_STRING_COMPUTATION)
-public class MyAliasAndParameterStringTransformer implements CommandContextTransformer<Message> {
+class MyAliasAndParameterStringTransformer implements CommandContextTransformer<Message> {
     @Override
     public <T extends Message> CommandContext<T> transform(CommandContext<T> commandContext, Phase phase) {
         return (!commandContext.getAlias().isPresent())
@@ -651,7 +656,7 @@ not found.
 _**Example:**_
 ```java
 @ApplicationScoped
-public class EventObserver {
+class EventObserver {
     private void commandNotFound(@ObservesAsync CommandNotFoundEventJavacord commandNotFoundEvent) {
         commandNotFoundEvent.getMessage()
                 .getChannel()
@@ -673,7 +678,7 @@ allowed.
 _**Example:**_
 ```java
 @ApplicationScoped
-public class EventObserver {
+class EventObserver {
     private void commandNotAllowed(@ObservesAsync CommandNotAllowedEventJavacord commandNotAllowedEvent) {
         commandNotAllowedEvent.getMessage()
                 .getChannel()
@@ -699,7 +704,7 @@ extends the [`CommandHandler`][CommandHandler JavaDoc] class. You are also welco
 implementation to the library for all users benefit. You should read the JavaDoc of the `CommandHandler` class and have
 a look at any of the existing implementations to get started with writing your own implementation. Most of the common
 logic should be done in the `CommandHandler` class already and just some framework-dependent things like attaching
-message listeners to the underlying framework need to be done in the sub-class.
+message listeners to the underlying framework need to be done in the subclass.