Skip to content

Commit 84b5e58

Browse files
sallybgbencap
authored andcommitted
Add more specific error messages for target alignment failures
1 parent 97cfc58 commit 84b5e58

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

src/dcd_mapping/align.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -478,9 +478,14 @@ def build_alignment_result(
478478
raise AlignmentError from e
479479

480480
# So long as force=True, the content of the records dict is irrelevant.
481-
alignment_result = align(
482-
patch_target_sequence_type(metadata, {}, force=True), silent
483-
)
481+
try:
482+
alignment_result = align(
483+
patch_target_sequence_type(metadata, {}, force=True), silent
484+
)
485+
except AlignmentError as e2:
486+
msg = f"BLAT alignment failed for {metadata.urn} at the protein level after failing at the nucleotide level."
487+
_logger.error(msg)
488+
raise AlignmentError(msg) from e2
484489

485490
else:
486491
alignment_result = fetch_alignment(metadata, silent)

src/dcd_mapping/mavedb_data.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,11 @@ def patch_target_sequence_type(
350350
_logger.debug(msg)
351351
continue
352352

353+
if target.target_gene_category != "protein_coding":
354+
msg = f"Cannot patch target sequence type for {metadata.urn} target {target_label} because target gene category is {target.target_gene_category}, not protein_coding."
355+
_logger.debug(msg)
356+
continue
357+
353358
msg = f"Changing target sequence type for {metadata.urn} target {target_label} from DNA to protein. (force was {force})."
354359
_logger.info(msg)
355360

0 commit comments

Comments
 (0)