Skip to content

Commit 2977ea6

Browse files
committed
Use Highlighted Variant in Score Set as entIri for ClinGen
1 parent ce029be commit 2977ea6

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/mavedb/lib/clingen/content_constructors.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from datetime import datetime
22
from uuid import uuid4
3+
from urllib.parse import quote_plus
34

45
from mavedb import __version__
56
from mavedb.constants import MAVEDB_BASE_GIT, MAVEDB_FRONTEND_URL
@@ -43,7 +44,7 @@ def construct_ldh_submission_entity(variant: Variant, mapped_variant: MappedVari
4344
"score": variant.data["score_data"]["score"], # type: ignore
4445
},
4546
"entId": variant.urn, # type: ignore
46-
"entIri": f"{MAVEDB_FRONTEND_URL}/{variant.urn}", # type: ignore
47+
"entIri": f"{MAVEDB_FRONTEND_URL}/score-sets/{quote_plus(variant.score_set.urn)}?variant={quote_plus(variant.urn)}", # type: ignore
4748
}
4849
]
4950
}

tests/lib/clingen/test_content_constructors.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from unittest.mock import patch
22
from uuid import UUID
3+
from urllib.parse import quote_plus
34

45
from mavedb.constants import MAVEDB_BASE_GIT, MAVEDB_FRONTEND_URL
56
from mavedb.lib.clingen.content_constructors import (
@@ -16,6 +17,7 @@
1617
VALID_VARIANT_URN,
1718
TEST_VALID_PRE_MAPPED_VRS_ALLELE_VRS2_X,
1819
TEST_VALID_POST_MAPPED_VRS_ALLELE_VRS2_X,
20+
VALID_SCORE_SET_URN,
1921
)
2022

2123

@@ -64,7 +66,10 @@ def test_construct_ldh_submission_entity(mock_variant, mock_mapped_variant):
6466
assert mapping["entContent"]["score"] == 1.0
6567

6668
assert mapping["entId"] == VALID_VARIANT_URN
67-
assert mapping["entIri"] == f"{MAVEDB_FRONTEND_URL}/{VALID_VARIANT_URN}"
69+
assert (
70+
mapping["entIri"]
71+
== f"{MAVEDB_FRONTEND_URL}/score-sets/{quote_plus(VALID_SCORE_SET_URN)}?variant={quote_plus(VALID_VARIANT_URN)}"
72+
)
6873

6974

7075
def test_construct_ldh_submission(mock_variant, mock_mapped_variant):

0 commit comments

Comments
 (0)