Skip to content

Commit 746be94

Browse files
committed
refactor: Move EntityType definition to types
1 parent de3622e commit 746be94

File tree

2 files changed

+20
-11
lines changed

2 files changed

+20
-11
lines changed

src/mavedb/lib/permissions/core.py

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
from typing import Any, Callable, Optional, Union
1+
from typing import Any, Callable, Optional
22

33
from mavedb.lib.authentication import UserData
44
from mavedb.lib.logging.context import save_to_logging_context
55
from mavedb.lib.permissions.actions import Action
66
from mavedb.lib.permissions.exceptions import PermissionException
77
from mavedb.lib.permissions.models import PermissionResponse
8+
from mavedb.lib.types.permissions import EntityType
89
from mavedb.models.collection import Collection
910
from mavedb.models.experiment import Experiment
1011
from mavedb.models.experiment_set import ExperimentSet
@@ -22,16 +23,6 @@
2223
user,
2324
)
2425

25-
# Define the supported entity types
26-
EntityType = Union[
27-
Collection,
28-
Experiment,
29-
ExperimentSet,
30-
ScoreCalibration,
31-
ScoreSet,
32-
User,
33-
]
34-
3526

3627
def has_permission(user_data: Optional[UserData], entity: EntityType, action: Action) -> PermissionResponse:
3728
"""
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
from typing import Union
2+
3+
from mavedb.models.collection import Collection
4+
from mavedb.models.experiment import Experiment
5+
from mavedb.models.experiment_set import ExperimentSet
6+
from mavedb.models.score_calibration import ScoreCalibration
7+
from mavedb.models.score_set import ScoreSet
8+
from mavedb.models.user import User
9+
10+
# Define the supported entity types
11+
EntityType = Union[
12+
Collection,
13+
Experiment,
14+
ExperimentSet,
15+
ScoreCalibration,
16+
ScoreSet,
17+
User,
18+
]

0 commit comments

Comments
 (0)