Merge pull request #208 from VariantEffect/bugfix/bencap/207/target-label-can-be-none

Only Sanitize Target Labels if they are a String

Author: jstone-dev

src/mavedb/view_models/target_sequence.py

@@ -49,9 +49,11 @@ def label_does_not_include_colon(cls, field_value, values, field, config) -> str
             if ":" in field_value:
                 raise ValidationError(f"Target sequence label `{field_value}` may not contain a colon.")
 
-        # Sanitize the label by stripping leading/trailing whitespace and replacing any internal whitespace with
-        # underscores. Fully qualified variants should never contain whitespace.
-        return sanitize_target_sequence_label(field_value)
+            # Sanitize the label by stripping leading/trailing whitespace and replacing any internal whitespace with
+            # underscores. Fully qualified variants should never contain whitespace.
+            return sanitize_target_sequence_label(field_value)
+
+        return field_value
 
 
 class TargetSequenceCreate(TargetSequenceModify):

tests/view_models/test_target_sequence.py

@@ -58,6 +58,21 @@ def test_target_sequence_label_is_sanitized():
     assert target_sequence.label == sanitize_target_sequence_label(label)
 
 
+def test_target_sequence_label_can_be_nonetype():
+    sequence_type = "dna"
+    label = None
+    sequence = SEQUENCE
+    taxonomy = TAXONOMY
+
+    target_sequence = TargetSequenceCreate(
+        sequence_type=sequence_type, sequence=sequence, taxonomy=taxonomy, label=label
+    )
+
+    assert target_sequence.sequence_type == sequence_type
+    assert target_sequence.sequence == SEQUENCE
+    assert target_sequence.label is None
+
+
 def test_cannot_create_target_sequence_with_label_containing_colon():
     sequence_type = "dna"
     label = "sequence:label"