feat: don't allow class-based calibrations during score set creatoin

Author: bencap

src/mavedb/routers/score_sets.py

@@ -1551,7 +1551,20 @@ async def create_score_set(
     score_calibrations: list[ScoreCalibration] = []
     if item_create.score_calibrations:
         for calibration_create in item_create.score_calibrations:
-            created_calibration_item = await create_score_calibration(db, calibration_create, user_data.user)
+            # TODO#592: Support for class-based calibrations on score set creation
+            if calibration_create.class_based:
+                logger.info(
+                    msg="Failed to create score set; Class-based calibrations are not supported on score set creation.",
+                    extra=logging_context(),
+                )
+                raise HTTPException(
+                    status_code=409,
+                    detail="Class-based calibrations are not supported on score set creation. Please create class-based calibrations after creating the score set.",
+                )
+
+            created_calibration_item = await create_score_calibration(
+                db, calibration_create, user_data.user, variant_classes=None
+            )
             created_calibration_item.investigator_provided = True  # necessarily true on score set creation
             score_calibrations.append(created_calibration_item)
 

tests/routers/test_score_set.py

@@ -35,6 +35,7 @@
     SAVED_PUBMED_PUBLICATION,
     SAVED_SHORT_EXTRA_LICENSE,
     TEST_BIORXIV_IDENTIFIER,
+    TEST_BRNICH_SCORE_CALIBRATION_CLASS_BASED,
     TEST_BRNICH_SCORE_CALIBRATION_RANGE_BASED,
     TEST_CROSSREF_IDENTIFIER,
     TEST_GNOMAD_DATA_VERSION,
@@ -234,6 +235,34 @@ def test_create_score_set_with_score_calibration(client, mock_publication_fetch,
     assert response.status_code == 200
 
 
+@pytest.mark.parametrize(
+    "mock_publication_fetch",
+    [
+        (
+            [
+                {"dbName": "PubMed", "identifier": f"{TEST_PUBMED_IDENTIFIER}"},
+                {"dbName": "bioRxiv", "identifier": f"{TEST_BIORXIV_IDENTIFIER}"},
+            ]
+        )
+    ],
+    indirect=["mock_publication_fetch"],
+)
+def test_cannot_create_score_set_with_class_based_calibration(client, mock_publication_fetch, setup_router_db):
+    experiment = create_experiment(client)
+    score_set = deepcopy(TEST_MINIMAL_SEQ_SCORESET)
+    score_set["experimentUrn"] = experiment["urn"]
+    score_set.update(
+        {
+            "scoreCalibrations": [deepcamelize(TEST_BRNICH_SCORE_CALIBRATION_CLASS_BASED)],
+        }
+    )
+
+    response = client.post("/api/v1/score-sets/", json=score_set)
+    assert response.status_code == 409
+    response_data = response.json()
+    assert "Class-based calibrations are not supported on score set creation" in response_data["detail"]
+
+
 @pytest.mark.parametrize(
     "mock_publication_fetch",
     [