-
Notifications
You must be signed in to change notification settings - Fork 2
Description
As it stands, there is an unnecessary risk of data loss of curated score ranges via the score set modify endpoint. The ScoreSetModify class currently accepts a property scoreRanges that should contain the full score range definition for a score set. We store both user provided and curated data in this property. If a user wanted to update their provided data, we currently force them to also send back the curated data or it will be overwritten. We shouldn't allow the user the ability to overwrite curated data, and they should only be allowed to access investigator provided ranges.
We should either:
- Accept an InvestigatorScoreRangesCreate object and place it into the ScoreSetRanges container object for them
- Accept a ScoreSetRanges object limited to the investigatorProvided key (or we ignore everything else)
In addition, it would be nice to provide an additional endpoint for updating score ranges. This endpoint could begin as an admin only endpoint, although it might transition to allow users to make certain additional changes to score ranges should they have appropriate permissions in the future.