Merge branch 'Chatterino:master' into master

Author: Veatra

.github/workflows/test-arch-linux.yml

@@ -28,9 +28,8 @@ jobs:
     steps:
       - name: Install dependencies
         run: |
-          sudo pacman -Sy
-          sudo pacman -S --noconfirm 'qt6-base' 'qt6-tools' 'boost-libs' 'openssl' 'qt6-imageformats' 'qtkeychain-qt6' 'qt6-svg' 'libnotify'
-          sudo pacman -S --noconfirm 'git' 'boost' 'cmake' 'benchmark'
+          sudo pacman -Syu --noconfirm
+          sudo pacman -S --noconfirm qt6-base qt6-tools boost-libs qt6-imageformats qtkeychain-qt6 qt6-svg libnotify git boost cmake benchmark
 
       - uses: actions/checkout@v5
         with:

CHANGELOG.md

@@ -5,9 +5,15 @@
 - Minor: Badges now link to their home page like emotes in the context menu. (#6437)
 - Minor: Fixed usercard resizing improperly without recent messages. (#6496)
 - Minor: Added setting for character limit of deleted messages. (#6491)
-- Minor: Added link support to plugin message API. (#6386)
+- Minor: Added link support to plugin message API. (#6386, #6527)
 - Minor: Added a description for the logging option under moderation tab. (#6514)
+- Minor: Added a menu action to sort tabs alphabetically. (#6551)
+- Minor: Fixed "edit hotkey" dialog opening like a normal window. (#6540)
 - Bugfix: Expose the "Extra extension IDs" setting on non-Windows systems too. (#6509)
+- Bugfix: Fixed some commands and filters not working as expected in seach popups. (#6539)
+- Bugfix: Fixed settings occasionally not opening when clicking on "Manage Accounts" in the account switcher. (#6543)
+- Bugfix: Fixed font change not resulting in forced layout update. (#6536)
+- Bugfix: Fixed scrollbar rect computation potentially resulting in overflows. (#6547)
 - Dev: Update release documentation. (#6498)
 - Dev: Make code sanitizers opt in with the `CHATTERINO_SANITIZER_SUPPORT` CMake option. After that's enabled, use the `SANITIZE_*` flag to enable individual sanitizers. (#6493)
 - Dev: Remove unused QTextCodec includes. (#6487)
@@ -21,8 +27,11 @@
 - Dev: Fixed warnings on Qt 6.10. (#6422)
 - Dev: Removed unused method in `Emojis`. (#6517)
 - Dev: Refactored `Emotes` into `EmoteController`. (#6516)
+- Dev: Fix Arch Linux partial upgrade error in CI. (#6553)
 - Dev: Added Qt keyword and warning flags project wide. (#6520)
 - Def: Fixed compilation error in tests with Clang 21. (#6519)
+- Dev: Fixed compilation warnings on clang-cl. (#6528)
+- Dev: Fixed compilation error in tests with Clang 21. (#6519)
 - Dev: The LuaLS meta files moved from `docs/plugin-meta.lua` to `docs/lua-meta/globals.lua`. (#6530)
 
 ## 2.5.4

docs/chatterino.d.ts

@@ -255,6 +255,7 @@ declare namespace c2 {
         JumpToChannel,
         CopyToClipboard,
         JumpToMessage,
+        InsertText,
     }
 
     enum MessageFlag {

docs/lua-meta/globals.lua

@@ -354,6 +354,7 @@ c2.LinkType = {
     JumpToChannel = {}, ---@type c2.LinkType.JumpToChannel
     CopyToClipboard = {}, ---@type c2.LinkType.CopyToClipboard
     JumpToMessage = {}, ---@type c2.LinkType.JumpToMessage
+    InsertText = {}, ---@type c2.LinkType.InsertText
 }
 
 -- Begin src/singletons/Fonts.hpp

docs/wip-plugins.md

@@ -621,6 +621,7 @@ This table describes links available to plugins.
 | `JumpToChannel`   | [Channel name](#channelget_name)   | Go to already open split with given channel                                          | `#pajlada`                            |
 | `CopyToClipboard` | Any Unicode text                   | Copy value to clipboard                                                              | n/a                                   |
 | `JumpToMessage`   | ID of the message                  | Highlight the message with given ID in current split, do nothing if it was not found | n/a                                   |
+| `InsertText`      | Any text, command or emote         | Insert text into split input                                                         | n/a                                   |
 
 ### Input/Output API
 

lib/miniaudio

@@ -1235,6 +1235,14 @@ if (MSVC)
         # Enable updated '__cplusplus' macro - workaround for CMake#18837
         /Zc:__cplusplus
     )
+
+    # Warnings on clang-cl
+    if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+        target_compile_options(${LIBRARY_PROJECT} PUBLIC
+            -Wno-missing-designated-field-initializers
+        )
+    endif()
+
     # Disable min/max macros from Windows.h
     target_compile_definitions(${LIBRARY_PROJECT} PUBLIC NOMINMAX)
 else ()

src/CMakeLists.txt

@@ -110,20 +110,7 @@ void showLastCrashDialog(const Args &args, const Paths &paths)
     dialog->exec();
 }
 
-void createRunningFile(const QString &path)
-{
-    QFile runningFile(path);
-
-    std::ignore = runningFile.open(QIODevice::WriteOnly | QIODevice::Truncate);
-    runningFile.flush();
-    runningFile.close();
-}
-
-void removeRunningFile(const QString &path)
-{
-    QFile::remove(path);
-}
-
+#if defined(NDEBUG) && !defined(CHATTERINO_WITH_CRASHPAD)
 std::chrono::steady_clock::time_point signalsInitTime;
 
 [[noreturn]] void handleSignal(int signum)
@@ -135,7 +122,7 @@ std::chrono::steady_clock::time_point signalsInitTime;
     {
         QProcess proc;
 
-#ifdef Q_OS_MAC
+#    ifdef Q_OS_MAC
         // On macOS, programs are bundled into ".app" Application bundles,
         // when restarting Chatterino that bundle should be opened with the "open"
         // terminal command instead of directly starting the underlying executable,
@@ -152,16 +139,17 @@ std::chrono::steady_clock::time_point signalsInitTime;
 
         CFRelease(appUrlRef);
         CFRelease(macPath);
-#else
+#    else
         proc.setProgram(QApplication::applicationFilePath());
         proc.setArguments({"--crash-recovery"});
-#endif
+#    endif
 
         proc.startDetached();
     }
 
     std::_Exit(signum);
 }
+#endif
 
 // We want to restart Chatterino when it crashes and the setting is set to
 // true.

src/RunGui.cpp

@@ -306,7 +306,10 @@ void Args::applyCustomChannelLayout(const QString &argValue, const Paths &paths)
 
             // Set first tab as selected
             tab.selected_ = window.tabs_.empty();
-            tab.rootNode_ = SplitNodeDescriptor{{"twitch", channelName}};
+            tab.rootNode_ = SplitNodeDescriptor{{
+                .type_ = "twitch",
+                .channelName_ = channelName,
+            }};
 
             window.tabs_.emplace_back(std::move(tab));
         }

src/common/Args.cpp

@@ -33,6 +33,8 @@ void ChannelChatters::addJoinedUser(const QString &user, bool isMod,
     assertInGuiThread();
 
     if (isIgnoredMessage(IgnoredMessageParameters{
+            .message = {},
+            .twitchUserID = {},
             .twitchUserLogin = user,
             .isMod = isMod,
             .isBroadcaster = isBroadcaster,
@@ -69,6 +71,8 @@ void ChannelChatters::addPartedUser(const QString &user, bool isMod,
     assertInGuiThread();
 
     if (isIgnoredMessage(IgnoredMessageParameters{
+            .message = {},
+            .twitchUserID = {},
             .twitchUserLogin = user,
             .isMod = isMod,
             .isBroadcaster = isBroadcaster,