Skip to content

More Rust API cleanup #492

More Rust API cleanup

More Rust API cleanup #492

Triggered via push May 4, 2025 19:42
Status Failure
Total duration 51s
Artifacts 1

rust.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 4 warnings
cargo fmt
Process completed with exit code 1.
cargo clippy
Error: Clippy has exited with exit code 101
the following explicit lifetimes could be elided: 'func: rust/src/low_level_il/lifting.rs#L670
error: the following explicit lifetimes could be elided: 'func --> rust/src/low_level_il/lifting.rs:670:6 | 670 | impl<'func, R> LowLevelILExpression<'func, Mutable, NonSSA<LiftedNonSSA>, R> | ^^^^^ ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 670 - impl<'func, R> LowLevelILExpression<'func, Mutable, NonSSA<LiftedNonSSA>, R> 670 + impl<R> LowLevelILExpression<'_, Mutable, NonSSA<LiftedNonSSA>, R> |
the following explicit lifetimes could be elided: 'func: rust/src/low_level_il/instruction.rs#L103
error: the following explicit lifetimes could be elided: 'func --> rust/src/low_level_il/instruction.rs:103:6 | 103 | impl<'func, M, F> Debug for LowLevelILInstruction<'func, M, F> | ^^^^^ ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 103 - impl<'func, M, F> Debug for LowLevelILInstruction<'func, M, F> 103 + impl<M, F> Debug for LowLevelILInstruction<'_, M, F> |
the following explicit lifetimes could be elided: 'func: rust/src/low_level_il/expression.rs#L653
error: the following explicit lifetimes could be elided: 'func --> rust/src/low_level_il/expression.rs:653:6 | 653 | impl<'func> LowLevelILExpressionKind<'func, Mutable, NonSSA<LiftedNonSSA>> { | ^^^^^ ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 653 - impl<'func> LowLevelILExpressionKind<'func, Mutable, NonSSA<LiftedNonSSA>> { 653 + impl LowLevelILExpressionKind<'_, Mutable, NonSSA<LiftedNonSSA>> { |
the following explicit lifetimes could be elided: 'func: rust/src/low_level_il/expression.rs#L205
error: the following explicit lifetimes could be elided: 'func --> rust/src/low_level_il/expression.rs:205:6 | 205 | impl<'func, F> LowLevelILExpression<'func, Finalized, F, ValueExpr> | ^^^^^ ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 205 - impl<'func, F> LowLevelILExpression<'func, Finalized, F, ValueExpr> 205 + impl<F> LowLevelILExpression<'_, Finalized, F, ValueExpr> |
the following explicit lifetimes could be elided: 'func: rust/src/low_level_il/expression.rs#L94
error: the following explicit lifetimes could be elided: 'func --> rust/src/low_level_il/expression.rs:94:6 | 94 | impl<'func, M, F, R> fmt::Debug for LowLevelILExpression<'func, M, F, R> | ^^^^^ ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 94 - impl<'func, M, F, R> fmt::Debug for LowLevelILExpression<'func, M, F, R> 94 + impl<M, F, R> fmt::Debug for LowLevelILExpression<'_, M, F, R> |
the following explicit lifetimes could be elided: 'func: rust/src/low_level_il/block.rs#L66
error: the following explicit lifetimes could be elided: 'func --> rust/src/low_level_il/block.rs:66:6 | 66 | impl<'func, M, F> Clone for LowLevelILBlock<'func, M, F> | ^^^^^ ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 66 - impl<'func, M, F> Clone for LowLevelILBlock<'func, M, F> 66 + impl<M, F> Clone for LowLevelILBlock<'_, M, F> |
the following explicit lifetimes could be elided: 'func: rust/src/low_level_il/block.rs#L54
error: the following explicit lifetimes could be elided: 'func --> rust/src/low_level_il/block.rs:54:6 | 54 | impl<'func, M, F> Debug for LowLevelILBlock<'func, M, F> | ^^^^^ ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-D clippy::needless-lifetimes` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]` help: elide the lifetimes | 54 - impl<'func, M, F> Debug for LowLevelILBlock<'func, M, F> 54 + impl<M, F> Debug for LowLevelILBlock<'_, M, F> |
associated functions `from_owned_raw`, `into_raw`, and `free_raw` are never used: rust/src/function.rs#L2529
error: associated functions `from_owned_raw`, `into_raw`, and `free_raw` are never used --> rust/src/function.rs:2529:19 | 2514 | impl PerformanceInfo { | -------------------- associated functions in this implementation ... 2529 | pub(crate) fn from_owned_raw(value: BNPerformanceInfo) -> Self { | ^^^^^^^^^^^^^^ ... 2535 | pub(crate) fn into_raw(value: Self) -> BNPerformanceInfo { | ^^^^^^^^ ... 2543 | pub(crate) fn free_raw(value: BNPerformanceInfo) { | ^^^^^^^^ | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]`
unused import: `UNIX_EPOCH`: rust/src/function.rs#L52
error: unused import: `UNIX_EPOCH` --> rust/src/function.rs:52:27 | 52 | use std::time::{Duration, UNIX_EPOCH}; | ^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_imports)]`
licensing
New version for cargo-about available: 0.7.1
cargo fmt: rust/src/types.rs#L934
Diff in /home/runner/work/binaryninja-api/binaryninja-api/rust/src/types.rs
cargo fmt: rust/src/string.rs#L80
Diff in /home/runner/work/binaryninja-api/binaryninja-api/rust/src/string.rs
cargo fmt: rust/src/interaction.rs#L36
Diff in /home/runner/work/binaryninja-api/binaryninja-api/rust/src/interaction.rs

Artifacts

Produced during runtime
Name Size Digest
license Expired
23 KB
sha256:a0a7150e8c079d188ac922f36d7c6d2b07a2ffe3c98e7a5953a133926a014c68