Skip to content

[Rust] Allow mapping between SSA and non-SSA forms of LLIL instructions / expressions #565

[Rust] Allow mapping between SSA and non-SSA forms of LLIL instructions / expressions

[Rust] Allow mapping between SSA and non-SSA forms of LLIL instructions / expressions #565

Triggered via pull request May 27, 2025 18:55
Status Failure
Total duration 53s
Artifacts 1

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 3 warnings
cargo fmt
Process completed with exit code 1.
cargo clippy
Error: Clippy has exited with exit code 101
this expression creates a reference which is immediately dereferenced by the compiler: rust/src/low_level_il/instruction.rs#L122
error: this expression creates a reference which is immediately dereferenced by the compiler --> rust/src/low_level_il/instruction.rs:122:36 | 122 | LowLevelILInstruction::new(&non_ssa, LowLevelInstructionIndex(idx)) | ^^^^^^^^ help: change this to: `non_ssa` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: rust/src/low_level_il/instruction.rs#L110
error: this expression creates a reference which is immediately dereferenced by the compiler --> rust/src/low_level_il/instruction.rs:110:36 | 110 | LowLevelILInstruction::new(&ssa, LowLevelInstructionIndex(idx)) | ^^^^ help: change this to: `ssa` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
this lifetime isn't used in the function definition: rust/src/low_level_il/instruction.rs#L107
error: this lifetime isn't used in the function definition --> rust/src/low_level_il/instruction.rs:107:21 | 107 | pub fn ssa_form<'a>(&self, ssa: &'func LowLevelILFunction<M, SSA>) -> LowLevelILInstruction<'func, M, SSA> { | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes = note: `-D clippy::extra-unused-lifetimes` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::extra_unused_lifetimes)]`
cargo fmt: rust/src/low_level_il/instruction.rs#L115
Diff in /home/runner/work/binaryninja-api/binaryninja-api/rust/src/low_level_il/instruction.rs
cargo fmt: rust/src/low_level_il/instruction.rs#L104
Diff in /home/runner/work/binaryninja-api/binaryninja-api/rust/src/low_level_il/instruction.rs
licensing
New version for cargo-about available: 0.7.1

Artifacts

Produced during runtime
Name Size Digest
license Expired
21.1 KB
sha256:3aee5e9a3f6fc26caa8b817d698fcbabeb952a8f219378c24ef59999b97ed7c7