Skip to content

WIP

WIP #1092

Triggered via push December 9, 2025 23:26
Status Failure
Total duration 43s
Artifacts 1

rust.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true: rust/src/types.rs#L1189
error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> rust/src/types.rs:1189:1 | 1189 | impl Into<ValueLocation> for Variable { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#from_over_into = note: `-D clippy::from-over-into` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::from_over_into)]` help: replace the `Into` implementation with `From<variable::Variable>` | 1189 ~ impl From<Variable> for ValueLocation { 1190 ~ fn from(val: Variable) -> Self { 1191 | ValueLocation { 1192 | components: vec![ValueLocationComponent { 1193 ~ variable: val, |
redundant closure: rust/src/types.rs#L1173
error: redundant closure --> rust/src/types.rs:1173:18 | 1173 | .map(|component| ValueLocationComponent::into_raw(component)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `ValueLocationComponent::into_raw` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#redundant_closure
redundant closure: rust/src/types.rs#L1164
error: redundant closure --> rust/src/types.rs:1164:22 | 1164 | .map(|component| ValueLocationComponent::from_raw(component)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `ValueLocationComponent::from_raw` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#redundant_closure = note: `-D clippy::redundant-closure` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`
this expression creates a reference which is immediately dereferenced by the compiler: rust/src/types.rs#L1141
error: this expression creates a reference which is immediately dereferenced by the compiler --> rust/src/types.rs:1141:45 | 1141 | let value_raw = Self::into_rust_raw(&self); | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
this lifetime isn't used in the function definition: rust/src/types.rs#L807
error: this lifetime isn't used in the function definition --> rust/src/types.rs:807:9 | 807 | 'a, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes
this lifetime isn't used in the function definition: rust/src/types.rs#L756
error: this lifetime isn't used in the function definition --> rust/src/types.rs:756:21 | 756 | pub fn function<'a, T: Into<ReturnValue>>( | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#extra_unused_lifetimes = note: `-D clippy::extra-unused-lifetimes` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::extra_unused_lifetimes)]`
useless conversion to the same type: `binaryninjacore_sys::BNValueLocation`: rust/src/function.rs#L1059
error: useless conversion to the same type: `binaryninjacore_sys::BNValueLocation` --> rust/src/function.rs:1059:63 | 1059 | .for_each(|location| ValueLocation::free_rust_raw(location.into())); | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `types::ValueLocation`: rust/src/function.rs#L1045
error: useless conversion to the same type: `types::ValueLocation` --> rust/src/function.rs:1045:59 | 1045 | .map(|location| ValueLocation::into_rust_raw(&location.into())) | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `binaryninjacore_sys::BNValueLocation`: rust/src/function.rs#L1036
error: useless conversion to the same type: `binaryninjacore_sys::BNValueLocation` --> rust/src/function.rs:1036:63 | 1036 | .for_each(|location| ValueLocation::free_rust_raw(location.into())); | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion
useless conversion to the same type: `types::ValueLocation`: rust/src/function.rs#L1022
error: useless conversion to the same type: `types::ValueLocation` --> rust/src/function.rs:1022:59 | 1022 | .map(|location| ValueLocation::into_rust_raw(&location.into())) | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `location` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
licensing
New version for cargo-about available: 0.8.4

Artifacts

Produced during runtime
Name Size Digest
license
26.5 KB
sha256:3d97fb0478be5f1f41100193c82485e5110030f43b3ac236388cc676de97ee25