wip

Author: emesare

view/sharedcache/core/SharedCacheController.cpp

@@ -66,7 +66,7 @@ bool SharedCacheController::LoadRegion(BinaryView &view, const CacheRegion &regi
     // Loads the given region into the BinaryView and marks it as loaded.
     // First check to make sure there isn't already a section at the address in the view.
     if (!view.GetSectionsAt(region.start).empty())
-        return true;
+        return false;
 
     auto vm = m_cache.GetVirtualMemory();
     auto reader = VirtualMemoryReader(vm);

view/sharedcache/ui/SharedCacheUINotifications.cpp

@@ -46,15 +46,27 @@ void UINotifications::OnViewChange(UIContext* context, ViewFrame* frame, const Q
 		if (!controller)
 			return;
 		if (auto foundRegion = controller->GetRegionContaining(addr))
-			controller->LoadRegion(*view, *foundRegion);
+		{
+			// If we did not load the region, then we don't need to run analysis.
+			if (!controller->LoadRegion(*view, *foundRegion))
+				return;
+			view->AddAnalysisOption("linearsweep");
+			view->UpdateAnalysis();
+		}
 	};
 
 	static auto loadImageAtAddr = [](Ref<BinaryView> view, uint64_t addr) {
 		auto controller = SharedCacheController::GetController(*view);
 		if (!controller)
 			return;
 		if (auto foundImage = controller->GetImageContaining(addr))
-			controller->LoadImage(*view, *foundImage);
+		{
+			// If we did not load the image, then we don't need to run analysis.
+			if (!controller->LoadImage(*view, *foundImage))
+				return;
+			view->AddAnalysisOption("linearsweep");
+			view->UpdateAnalysis();
+		}
 	};
 
 	auto loadImageNameAction = [](const UIActionContext& ctx) {