Fix possible double free with platform recognizer in Rust API

emesare · emesare · commit 0cc29835da6c · 2025-03-19T11:47:05.000-04:00
diff --git a/rust/src/custom_binary_view.rs b/rust/src/custom_binary_view.rs
@@ -280,7 +280,7 @@ pub trait BinaryViewTypeExt: BinaryViewTypeBase {
             let bv = unsafe { BinaryView::from_raw(bv).to_owned() };
             let metadata = unsafe { Metadata::from_raw(metadata).to_owned() };
             match (context.recognizer)(&bv, &metadata) {
-                Some(plat) => plat.handle,
+                Some(plat) => unsafe { Ref::into_raw(plat).handle },
                 None => std::ptr::null_mut(),
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -280,7 +280,7 @@ pub trait BinaryViewTypeExt: BinaryViewTypeBase {`
`280`	`280`	`let bv = unsafe { BinaryView::from_raw(bv).to_owned() };`
`281`	`281`	`let metadata = unsafe { Metadata::from_raw(metadata).to_owned() };`
`282`	`282`	`match (context.recognizer)(&bv, &metadata) {`
`283`		`- Some(plat) => plat.handle,`
	`283`	`+ Some(plat) => unsafe { Ref::into_raw(plat).handle },`
`284`	`284`	`None => std::ptr::null_mut(),`
`285`	`285`	`}`
`286`	`286`	`}`