[SVD] Use type-safe activity configuration

Author: bdash

plugins/svd/src/lib.rs

@@ -6,20 +6,10 @@ use crate::settings::LoadSettings;
 use binaryninja::binary_view::{BinaryView, BinaryViewBase, BinaryViewExt};
 use binaryninja::command::Command;
 use binaryninja::logger::Logger;
+use binaryninja::workflow::activity::{Config, Eligibility};
 use binaryninja::workflow::{Activity, AnalysisContext, Workflow};
 use log::LevelFilter;
 
-pub const LOADER_ACTIVITY_NAME: &str = "analysis.svd.loader";
-const LOADER_ACTIVITY_CONFIG: &str = r#"{
-    "name": "analysis.svd.loader",
-    "title" : "SVD Loader",
-    "description": "This analysis step applies SVD info to the view...",
-    "eligibility": {
-        "auto": {},
-        "runOnce": true
-    }
-}"#;
-
 struct LoadSVDFile;
 
 impl Command for LoadSVDFile {
@@ -113,12 +103,17 @@ fn plugin_init() {
     };
 
     // Register new workflow activity to load svd information.
-    let old_module_meta_workflow = Workflow::instance("core.module.metaAnalysis");
-    let module_meta_workflow = old_module_meta_workflow.clone_to("core.module.metaAnalysis");
-    let loader_activity = Activity::new_with_action(LOADER_ACTIVITY_CONFIG, loader_activity);
+    let module_meta_workflow = Workflow::cloned("core.module.metaAnalysis");
+    let loader_config = Config::action(
+        "analysis.svd.loader",
+        "SVD Loader",
+        "This analysis step applies SVD info to the view...",
+    )
+    .eligibility(Eligibility::auto().run_once(true));
+    let loader_activity = Activity::new_with_action(&loader_config, loader_activity);
     module_meta_workflow
         .register_activity(&loader_activity)
         .unwrap();
-    module_meta_workflow.insert("core.module.loadDebugInfo", [LOADER_ACTIVITY_NAME]);
+    module_meta_workflow.insert("core.module.loadDebugInfo", [&loader_config.name]);
     module_meta_workflow.register().unwrap();
 }