Fix double ref increment for misc Repository C++ APIs

emesare · emesare · commit 1137ea183004 · 2025-02-06T22:54:17.000-05:00
Noticed these when reviewing the Rust Repository API
diff --git a/pluginmanager.cpp b/pluginmanager.cpp
@@ -288,7 +288,7 @@ vector<Ref<RepoPlugin>> Repository::GetPlugins() const
 
 Ref<RepoPlugin> Repository::GetPluginByPath(const string& pluginPath)
 {
-	return new RepoPlugin(BNNewPluginReference(BNRepositoryGetPluginByPath(m_object, pluginPath.c_str())));
+	return new RepoPlugin(BNRepositoryGetPluginByPath(m_object, pluginPath.c_str()));
 }
 
 string Repository::GetFullPath() const
@@ -335,10 +335,10 @@ bool RepositoryManager::AddRepository(const std::string& url,
 
 Ref<Repository> RepositoryManager::GetRepositoryByPath(const std::string& repoPath)
 {
-	return new Repository(BNNewRepositoryReference(BNRepositoryGetRepositoryByPath(m_object, repoPath.c_str())));
+	return new Repository(BNRepositoryGetRepositoryByPath(m_object, repoPath.c_str()));
 }
 
 Ref<Repository> RepositoryManager::GetDefaultRepository()
 {
-	return new Repository(BNNewRepositoryReference(BNRepositoryManagerGetDefaultRepository(m_object)));
+	return new Repository(BNRepositoryManagerGetDefaultRepository(m_object));
 }

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ vector<Ref<RepoPlugin>> Repository::GetPlugins() const`
`288`	`288`
`289`	`289`	`Ref<RepoPlugin> Repository::GetPluginByPath(const string& pluginPath)`
`290`	`290`	`{`
`291`		`- return new RepoPlugin(BNNewPluginReference(BNRepositoryGetPluginByPath(m_object, pluginPath.c_str())));`
	`291`	`+ return new RepoPlugin(BNRepositoryGetPluginByPath(m_object, pluginPath.c_str()));`
`292`	`292`	`}`
`293`	`293`
`294`	`294`	`string Repository::GetFullPath() const`
`@@ -335,10 +335,10 @@ bool RepositoryManager::AddRepository(const std::string& url,`
`335`	`335`
`336`	`336`	`Ref<Repository> RepositoryManager::GetRepositoryByPath(const std::string& repoPath)`
`337`	`337`	`{`
`338`		`- return new Repository(BNNewRepositoryReference(BNRepositoryGetRepositoryByPath(m_object, repoPath.c_str())));`
	`338`	`+ return new Repository(BNRepositoryGetRepositoryByPath(m_object, repoPath.c_str()));`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`Ref<Repository> RepositoryManager::GetDefaultRepository()`
`342`	`342`	`{`
`343`		`- return new Repository(BNNewRepositoryReference(BNRepositoryManagerGetDefaultRepository(m_object)));`
	`343`	`+ return new Repository(BNRepositoryManagerGetDefaultRepository(m_object));`
`344`	`344`	`}`