wip

Author: emesare

view/sharedcache/ui/dsctriage.cpp

@@ -352,6 +352,11 @@ DSCTriageView::DSCTriageView(QWidget* parent, BinaryViewRef data) : QWidget(pare
 	m_layout->addWidget(m_triageTabs);
 	setLayout(m_layout);
 
+	// In case we have already initialized the controller (user has opened this view type again)
+	// we will call refresh data. If this is the first triage view constructed (i.e. before view init) then this
+	// will do nothing.
+	RefreshData();
+
 	m_triageTabs->selectWidget(defaultWidget);
 }
 

view/sharedcache/workflow/ObjCActivity.cpp

@@ -1,6 +1,8 @@
 #include "ObjCActivity.h"
 #include "lowlevelilinstruction.h"
 
+// TODO: Consolidate this with the Obj-C workflow at some point https://github.com/Vector35/workflow_objc
+
 using namespace BinaryNinja;
 
 void ObjCActivity::Register(Workflow &workflow)

view/sharedcache/workflow/SharedCacheWorkflow.cpp

@@ -34,7 +34,7 @@ std::shared_ptr<GlobalWorkflowState> GetGlobalWorkflowState(Ref<BinaryView> view
 	static std::unordered_map<uint64_t, std::shared_ptr<GlobalWorkflowState>> globalWorkflowState;
 
 	std::shared_lock<std::shared_mutex> readLock(globalWorkflowStateMutex);
-	uint64_t viewId = view->GetFile()->GetSessionId();
+	const uint64_t viewId = view->GetFile()->GetSessionId();
 	auto foundState = globalWorkflowState.find(viewId);
 	if (foundState != globalWorkflowState.end())
 		return foundState->second;