Skip to content

Commit 3286a98

Browse files
committed
[SharedCache] Improper nesting in workflow
oops!
1 parent 48f107d commit 3286a98

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

view/sharedcache/workflow/SharedCacheWorkflow.cpp

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -368,25 +368,25 @@ void FixupOffImageCalls(Ref<AnalysisContext> ctx)
368368
}
369369
}
370370
}
371-
else if (destExpr.operation == MLIL_CONST_PTR)
371+
}
372+
else if (destExpr.operation == MLIL_CONST_PTR)
373+
{
374+
// 4 @ 18aa08208 (MLIL_JUMP jump((MLIL_CONST_PTR.q 0x18c1369f0)))
375+
auto targetAddr = destExpr.GetConstant();
376+
if (!view->IsValidOffset(targetAddr))
372377
{
373-
// 4 @ 18aa08208 (MLIL_JUMP jump((MLIL_CONST_PTR.q 0x18c1369f0)))
374-
auto targetAddr = destExpr.GetConstant();
375-
if (!view->IsValidOffset(targetAddr))
376-
{
377-
tryAddRegion(targetAddr);
378-
}
378+
tryAddRegion(targetAddr);
379379
}
380-
else if (destExpr.operation == MLIL_LOAD_SSA)
380+
}
381+
else if (destExpr.operation == MLIL_LOAD_SSA)
382+
{
383+
auto ptrExpr = destExpr.GetSourceExpr<MLIL_LOAD_SSA>();
384+
if (ptrExpr.operation == MLIL_CONST_PTR)
381385
{
382-
auto ptrExpr = destExpr.GetSourceExpr<MLIL_LOAD_SSA>();
383-
if (ptrExpr.operation == MLIL_CONST_PTR)
386+
auto targetAddr = ptrExpr.GetConstant();
387+
if (!view->IsValidOffset(targetAddr))
384388
{
385-
auto targetAddr = ptrExpr.GetConstant();
386-
if (!view->IsValidOffset(targetAddr))
387-
{
388-
tryAddRegion(targetAddr);
389-
}
389+
tryAddRegion(targetAddr);
390390
}
391391
}
392392
}

0 commit comments

Comments
 (0)