Prevent nullptr deref if we don't find image.

fuzyll · fuzyll · commit 37e20cc30d57 · 2025-04-14T09:37:09.000-04:00
diff --git a/view/kernelcache/core/KernelCache.cpp b/view/kernelcache/core/KernelCache.cpp
@@ -602,12 +602,12 @@ bool KernelCache::LoadImageWithInstallName(std::lock_guard<std::mutex>& lock, st
 			break;
 		}
 	}
-	const auto header = LoadHeaderForAddress(m_kcView, targetImage->headerFileLocation, targetImage->installName);
+	if (!targetImage)
+		return false;
 
+	const auto header = LoadHeaderForAddress(m_kcView, targetImage->headerFileLocation, targetImage->installName);
 	if (!header)
-	{
 		return false;
-	}
 
 	m_modifiedState->viewState = KCViewStateLoadedWithImages;
 

Original file line number	Diff line number	Diff line change
`@@ -602,12 +602,12 @@ bool KernelCache::LoadImageWithInstallName(std::lock_guard<std::mutex>& lock, st`
`602`	`602`	`break;`
`603`	`603`	`}`
`604`	`604`	`}`
`605`		`- const auto header = LoadHeaderForAddress(m_kcView, targetImage->headerFileLocation, targetImage->installName);`
	`605`	`+ if (!targetImage)`
	`606`	`+ return false;`
`606`	`607`
	`608`	`+ const auto header = LoadHeaderForAddress(m_kcView, targetImage->headerFileLocation, targetImage->installName);`
`607`	`609`	`if (!header)`
`608`		`- {`
`609`	`610`	`return false;`
`610`		`- }`
`611`	`611`
`612`	`612`	`m_modifiedState->viewState = KCViewStateLoadedWithImages;`
`613`	`613`