Expose analysis' system call type and name retrieval

Previously we only really had a way to access the platform system call information, this was missing the system call information found in type libraries

Fixes #7089

Author: emesare

binaryninjaapi.h

@@ -6425,6 +6425,8 @@ namespace BinaryNinja {
 		void UndefineType(const std::string& id);
 		void UndefineUserType(const QualifiedName& name);
 		void RenameType(const QualifiedName& oldName, const QualifiedName& newName);
+		Ref<Type> GetSystemCallType(Platform* platform, uint32_t id);
+		std::string GetSystemCallName(Platform* platform, uint32_t id);
 
 		void RegisterPlatformTypes(Platform* platform);
 

binaryninjacore.h

@@ -5424,6 +5424,8 @@ extern "C"
 	BINARYNINJACOREAPI void BNUndefineUserAnalysisType(BNBinaryView* view, BNQualifiedName* name);
 	BINARYNINJACOREAPI void BNRenameAnalysisType(
 	    BNBinaryView* view, BNQualifiedName* oldName, BNQualifiedName* newName);
+	BINARYNINJACOREAPI BNType* BNGetAnalysisSystemCallType(BNBinaryView* view, BNPlatform* platform, uint32_t id);
+	BINARYNINJACOREAPI char* BNGetAnalysisSystemCallName(BNBinaryView* view, BNPlatform* platform, uint32_t id);
 	BINARYNINJACOREAPI char* BNGenerateAutoTypeId(const char* source, BNQualifiedName* name);
 	BINARYNINJACOREAPI char* BNGenerateAutoPlatformTypeId(BNPlatform* platform, BNQualifiedName* name);
 	BINARYNINJACOREAPI char* BNGenerateAutoDemangledTypeId(BNQualifiedName* name);

binaryview.cpp

@@ -4392,6 +4392,24 @@ void BinaryView::RenameType(const QualifiedName& oldName, const QualifiedName& n
 }
 
 
+Ref<Type> BinaryView::GetSystemCallType(Platform *platform, uint32_t id)
+{
+	BNType* type = BNGetAnalysisSystemCallType(m_object, platform->m_object, id);
+	if (!type)
+		return nullptr;
+	return new Type(type);
+}
+
+
+std::string BinaryView::GetSystemCallName(Platform *platform, uint32_t id)
+{
+	char* name = BNGetAnalysisSystemCallName(m_object, platform->m_object, id);
+	string result = name;
+	BNFreeString(name);
+	return result;
+}
+
+
 void BinaryView::RegisterPlatformTypes(Platform* platform)
 {
 	BNRegisterPlatformTypes(m_object, platform->GetObject());

lang/c/pseudoc.cpp

@@ -2705,13 +2705,14 @@ void PseudoCFunction::GetExprTextInternal(const HighLevelILInstruction& instr, H
 			if (GetFunction() && (operandList.size() > 0) && (operandList[0].operation == HLIL_CONST))
 			{
 				const auto platform = GetFunction()->GetPlatform();
+				const auto view = GetFunction()->GetView();
 				if (platform)
 				{
 					const auto syscall = (uint32_t)operandList[0].GetConstant<HLIL_CONST>();
-					const auto syscallName = platform->GetSystemCallName(syscall);
+					const auto syscallName = view->GetSystemCallName(platform, syscall);
 					if (settings && settings->GetCallParameterHints() != NeverShowParameterHints)
 					{
-						const auto functionType = platform->GetSystemCallType(syscall);
+						const auto functionType = view->GetSystemCallType(platform, syscall);
 						if (functionType && (functionType->GetClass() == FunctionTypeClass))
 							namedParams = functionType->GetParameters();
 					}

lang/rust/pseudorust.cpp

@@ -2723,13 +2723,14 @@ void PseudoRustFunction::GetExprText(const HighLevelILInstruction& instr, HighLe
 			if (GetFunction() && (operandList.size() > 0) && (operandList[0].operation == HLIL_CONST))
 			{
 				const auto platform = GetFunction()->GetPlatform();
+				const auto view = GetFunction()->GetView();
 				if (platform)
 				{
 					const auto syscall = (uint32_t)operandList[0].GetConstant<HLIL_CONST>();
-					const auto syscallName = platform->GetSystemCallName(syscall);
+					const auto syscallName = view->GetSystemCallName(platform, syscall);
 					if (settings && settings->GetCallParameterHints() != NeverShowParameterHints)
 					{
-						const auto functionType = platform->GetSystemCallType(syscall);
+						const auto functionType = view->GetSystemCallType(platform, syscall);
 						if (functionType && (functionType->GetClass() == FunctionTypeClass))
 							namedParams = functionType->GetParameters();
 					}

python/binaryview.py

@@ -8293,6 +8293,26 @@ def rename_type(self, old_name: '_types.QualifiedNameType', new_name: '_types.Qu
 		_new_name = _types.QualifiedName(new_name)._to_core_struct()
 		core.BNRenameAnalysisType(self.handle, _old_name, _new_name)
 
+	def get_system_call_type(self, id: int, platform: Optional['_platform.Platform'] = None) -> Optional['_types.Type']:
+		if platform is None:
+			platform = self.platform
+		if platform is None:
+			raise Exception("Unable to retrieve system call type without a platform")
+		handle = core.BNGetAnalysisSystemCallType(self.handle, platform.handle, id)
+		if handle is None:
+			return None
+		return _types.Type.create(handle, platform=platform)
+
+	def get_system_call_name(self, id: int, platform: Optional['_platform.Platform'] = None) -> Optional[str]:
+		if platform is None:
+			platform = self.platform
+		if platform is None:
+			raise Exception("Unable to retrieve system call type without a platform")
+		result = core.BNGetAnalysisSystemCallName(self.handle, platform.handle, id)
+		if result is None:
+			return None
+		return result
+
 	def import_library_type(self, name: str, lib: Optional[typelibrary.TypeLibrary] = None) -> Optional['_types.Type']:
 		"""
 		``import_library_type`` recursively imports a type from the specified type library, or, if