[MachO] Treat a binary as containing Objective-C metadata if it has __objc_stubs

bdash · bdash · commit 44e415514493 · 2025-07-09T07:59:54.000-07:00
`__objc_stubs` is not technically Objective-C metadata, but binaries
containing Objective-C stubs need the same processing.

`MachoView` was previously only enabling the Objective-C workflow if it
thinks there is type metadata. The same criteria was used to determine
whether to process Objective-C metadata via `MachoObjCProcessor`.

This meant binaries with `__objc_stubs` but no Objective-C type metadata
were not running the Objective-C workflow, preventing stub functions
from being inlined during analysis.
diff --git a/view/macho/objc.cpp b/view/macho/objc.cpp
@@ -83,8 +83,8 @@ std::shared_ptr<ObjCReader> MachoObjCProcessor::GetReader()
 
 bool MachoObjCProcessor::ViewHasObjCMetadata(BinaryView* data)
 {
-	return (data->GetSectionByName("__objc_classlist") || data->GetSectionByName("__objc_catlist")
-		|| data->GetSectionByName("__objc_protolist"));
+	return data->GetSectionByName("__objc_classlist") || data->GetSectionByName("__objc_catlist")
+		|| data->GetSectionByName("__objc_protolist") || data->GetSectionByName("__objc_stubs");
 }
 
 MachoObjCProcessor::MachoObjCProcessor(BinaryView* data) :

Original file line number	Diff line number	Diff line change
`@@ -83,8 +83,8 @@ std::shared_ptr<ObjCReader> MachoObjCProcessor::GetReader()`
`83`	`83`
`84`	`84`	`bool MachoObjCProcessor::ViewHasObjCMetadata(BinaryView* data)`
`85`	`85`	`{`
`86`		`- return (data->GetSectionByName("__objc_classlist") \|\| data->GetSectionByName("__objc_catlist")`
`87`		`- \|\| data->GetSectionByName("__objc_protolist"));`
	`86`	`+ return data->GetSectionByName("__objc_classlist") \|\| data->GetSectionByName("__objc_catlist")`
	`87`	`+ \|\| data->GetSectionByName("__objc_protolist") \|\| data->GetSectionByName("__objc_stubs");`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`MachoObjCProcessor::MachoObjCProcessor(BinaryView* data) :`