wip

Author: emesare

view/sharedcache/api/python/sharedcache.py

@@ -125,7 +125,7 @@ def load_image_containing_address(self, addr, skipObjC = False):
 		return sccore.BNDSCViewLoadImageContainingAddress(self.handle, addr, skipObjC)
 
 	def process_objc_sections_for_image_with_install_name(self, installName):
-		return sccore.BNDSCViewProcessObjCSectionsForImageWithInstallName(self.handle, installName, False)
+		return sccore.BNDSCViewProcessObjCSectionsForImageWithInstallName(self.handle, installName)
 
 	def process_all_objc_sections(self):
 		return sccore.BNDSCViewProcessAllObjCSections(self.handle)

view/sharedcache/api/sharedcache.cpp

@@ -55,10 +55,9 @@ std::vector<std::string> SharedCache::GetAvailableImages()
 	return result;
 }
 
-void SharedCache::ProcessObjCSectionsForImageWithInstallName(std::string installName)
+void SharedCache::ProcessObjCSectionsForImageWithInstallName(const std::string& installName)
 {
-	char* str = BNAllocString(installName.c_str());
-	BNDSCViewProcessObjCSectionsForImageWithInstallName(m_object, str, true);
+	BNDSCViewProcessObjCSectionsForImageWithInstallName(m_object, installName.c_str());
 }
 
 void SharedCache::ProcessAllObjCSections()

view/sharedcache/api/sharedcacheapi.h

@@ -147,7 +147,7 @@ namespace SharedCacheAPI {
 		bool LoadImageContainingAddress(uint64_t addr, bool skipObjC = false);
 		std::vector<std::string> GetAvailableImages();
 
-		void ProcessObjCSectionsForImageWithInstallName(std::string installName);
+		void ProcessObjCSectionsForImageWithInstallName(const std::string& installName);
 		void ProcessAllObjCSections();
 
 		std::vector<DSCSymbol> LoadAllSymbolsAndWait();

view/sharedcache/api/sharedcachecore.h

@@ -127,11 +127,11 @@ extern "C"
 
 	SHAREDCACHE_FFI_API char** BNDSCViewGetInstallNames(BNSharedCache* cache, size_t* count);
 
-	SHAREDCACHE_FFI_API bool BNDSCViewLoadImageWithInstallName(BNSharedCache* cache, char* name, bool skipObjC);
+	SHAREDCACHE_FFI_API bool BNDSCViewLoadImageWithInstallName(BNSharedCache* cache, const char* name, bool skipObjC);
 	SHAREDCACHE_FFI_API bool BNDSCViewLoadSectionAtAddress(BNSharedCache* cache, uint64_t name);
 	SHAREDCACHE_FFI_API bool BNDSCViewLoadImageContainingAddress(BNSharedCache* cache, uint64_t address, bool skipObjC);
 
-	SHAREDCACHE_FFI_API void BNDSCViewProcessObjCSectionsForImageWithInstallName(BNSharedCache* cache, char* name, bool deallocName);
+	SHAREDCACHE_FFI_API void BNDSCViewProcessObjCSectionsForImageWithInstallName(BNSharedCache* cache, const char* name);
 	SHAREDCACHE_FFI_API void BNDSCViewProcessAllObjCSections(BNSharedCache* cache);
 
 	SHAREDCACHE_FFI_API char* BNDSCViewGetNameForAddress(BNSharedCache* cache, uint64_t address);
@@ -156,7 +156,7 @@ extern "C"
 	SHAREDCACHE_FFI_API void BNDSCFindSymbolAtAddressAndApplyToAddress(BNSharedCache* cache, uint64_t symbolLocation, uint64_t targetLocation, bool triggerReanalysis);
 
 	SHAREDCACHE_FFI_API char* BNDSCViewGetImageHeaderForAddress(BNSharedCache* cache, uint64_t address);
-	SHAREDCACHE_FFI_API char* BNDSCViewGetImageHeaderForName(BNSharedCache* cache, char* name);
+	SHAREDCACHE_FFI_API char* BNDSCViewGetImageHeaderForName(BNSharedCache* cache, const char* name);
 
 	SHAREDCACHE_FFI_API BNDSCMemoryUsageInfo BNDSCViewGetMemoryUsageInfo();
 

view/sharedcache/core/CMakeLists.txt

@@ -9,7 +9,7 @@ if((NOT BN_API_PATH) AND (NOT BN_INTERNAL_BUILD))
     endif()
 endif()
 
-file(GLOB SOURCES *.cpp *.h ../../../objectivec/*)
+file(GLOB_RECURSE SOURCES *.cpp *.h ../../../objectivec/*)
 
 add_library(sharedcachecore OBJECT ${SOURCES})
 

view/sharedcache/core/DSCView.cpp

@@ -13,6 +13,9 @@
  * */
 
 #include "DSCView.h"
+
+#include "FileAccessorCache.h"
+#include "MappedFileAccessor.h"
 #include "view/macho/machoview.h"
 #include "SharedCache.h"
 
@@ -196,7 +199,7 @@ bool DSCView::Init()
 	auto metadataVersion = SharedCacheCore::SharedCacheMetadata::ViewMetadataVersion(GetParentView());
 	if (metadataVersion.has_value() && metadataVersion.value() != METADATA_VERSION)
 	{
-		// TODO: This is fucked up lmaooooo
+		// TODO: dont worry this will go away with the refactor, eta this week idk.
 		ShowMessageBox("Invalid Shared Cache Metadata!", "The BNDB shared cache metadata was created with a different version of the Shared Cache view, to continue the metadata has to be recreated. You will need to add your images back again.");
 	}
 
@@ -650,8 +653,11 @@ DSCViewType::DSCViewType() : BinaryViewType(VIEW_NAME, VIEW_NAME)
 
 void DSCViewType::Register()
 {
-	MMappedFileAccessor::InitialVMSetup();
-	std::atexit(VMShutdown);
+	auto fdLimit = AdjustFileDescriptorLimit();
+	BinaryNinja::LogDebug("Shared Cache processing initialized with a max file descriptor limit of %lld", fdLimit);
+
+	// Adjust the global accessor cache to the fdlimit.
+	FileAccessorCache::Global().SetCacheSize(fdLimit);
 
 	static DSCViewType type;
 	BinaryViewType::Register(&type);