Skip to content

Commit 4ba6142

Browse files
ElykDeerElykDeer
committed
WIP Manifest v2 support - removes BNPluginGetLicenseText, BNPluginGetCommit, BNPluginGetProjectData, and BNCreateRepositoryManager, and more...
1 parent 0493db0 commit 4ba6142

File tree

7 files changed

+142
-377
lines changed

7 files changed

+142
-377
lines changed

‎binaryninjaapi.h‎

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16799,25 +16799,21 @@ namespace BinaryNinja {
1679916799
std::vector<std::string> GetInstallPlatforms() const;
1680016800
std::string GetPath() const;
1680116801
std::string GetSubdir() const;
16802-
std::string GetDependencies() const;
16803-
std::string GetPluginDirectory() const;
16802+
// std::string GetDependencies() const; // Change to GetMostRecentVersion()->GetDependencies()
16803+
// std::string GetPluginDirectory() const; // Change to GetMostRecentVersion()->GetPluginDirectory()
1680416804
std::string GetAuthor() const;
1680516805
std::string GetDescription() const;
16806-
std::string GetLicenseText() const;
16807-
std::string GetLongdescription() const;
16806+
// std::string GetLongdescription() const; // Change to GetMostRecentVersion()->GetLongDescription()
1680816807
std::string GetName() const;
1680916808
std::vector<PluginType> GetPluginTypes() const;
16810-
std::string GetPackageUrl() const;
16809+
// std::string GetPackageUrl() const; // Change to GetMostRecentVersion()->GetPackageUrl()
1681116810
std::string GetProjectUrl() const;
16812-
std::string GetAuthorUrl() const;
16813-
std::string GetVersion() const;
16814-
std::string GetCommit() const;
16811+
// std::string GetVersion() const; // Meed to change to GetVersions generator object sorta thing
1681516812
std::string GetRepository() const;
16816-
std::string GetProjectData();
16817-
BNVersionInfo GetMinimumVersionInfo() const;
16818-
BNVersionInfo GetMaximumVersionInfo() const;
16819-
uint64_t GetLastUpdate();
16820-
bool IsViewOnly() const;
16813+
// BNVersionInfo GetMinimumVersionInfo() const; // Change to GetMostRecentVersion()->GetMinimumVersionInfo()
16814+
// BNVersionInfo GetMaximumVersionInfo() const; // Change to GetMostRecentVersion()->GetMaximumVersionInfo()
16815+
// uint64_t GetLastUpdate(); // Change to GetMostRecentVersion()->GetLastUpdate()
16816+
// bool IsViewOnly() const; // idk what I want to do about this I need to talk to josh about it again
1682116817
bool IsBeingDeleted() const;
1682216818
bool IsBeingUpdated() const;
1682316819
bool IsInstalled() const;
@@ -16830,8 +16826,8 @@ namespace BinaryNinja {
1683016826
bool AreDependenciesBeingInstalled() const;
1683116827

1683216828
bool Uninstall();
16833-
bool Install();
16834-
bool InstallDependencies();
16829+
// bool Install();
16830+
// bool InstallDependencies();
1683516831
// `force` ignores optional checks for platform/api compliance
1683616832
bool Enable(bool force);
1683716833
bool Disable();
@@ -16862,7 +16858,7 @@ namespace BinaryNinja {
1686216858
public CoreRefCountObject<BNRepositoryManager, BNNewRepositoryManagerReference, BNFreeRepositoryManager>
1686316859
{
1686416860
public:
16865-
RepositoryManager(const std::string& enabledPluginsPath);
16861+
// RepositoryManager();
1686616862
RepositoryManager(BNRepositoryManager* repoManager);
1686716863
RepositoryManager();
1686816864
bool CheckForUpdates();

‎binaryninjacore.h‎

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3686,6 +3686,7 @@ extern "C"
36863686
BINARYNINJACOREAPI bool BNIsPluginsEnabled(void);
36873687
BINARYNINJACOREAPI void BNInitUserPlugins(void); // Deprecated, use BNInitPlugins
36883688
BINARYNINJACOREAPI void BNInitRepoPlugins(void);
3689+
BINARYNINJACOREAPI void BNLoadPluginsInDirectory(const char*);
36893690

36903691
BINARYNINJACOREAPI char* BNGetInstallDirectory(void);
36913692
BINARYNINJACOREAPI char* BNGetBundledPluginDirectory(void);
@@ -7214,40 +7215,36 @@ extern "C"
72147215
BNType** outType, BNQualifiedName* outVarName, BNBinaryView* view, bool simplify);
72157216

72167217
// Plugin repository APIs
7217-
BINARYNINJACOREAPI char** BNPluginGetApis(BNRepoPlugin* p, size_t* count);
7218+
// BINARYNINJACOREAPI char** BNPluginGetApis(BNRepoPlugin* p, size_t* count);
72187219
BINARYNINJACOREAPI const char* BNPluginGetAuthor(BNRepoPlugin* p);
72197220
BINARYNINJACOREAPI const char* BNPluginGetDescription(BNRepoPlugin* p);
7220-
BINARYNINJACOREAPI const char* BNPluginGetLicenseText(BNRepoPlugin* p);
7221-
BINARYNINJACOREAPI const char* BNPluginGetLongdescription(BNRepoPlugin* p);
7222-
BINARYNINJACOREAPI BNVersionInfo BNPluginGetMinimumVersionInfo(BNRepoPlugin* p);
7223-
BINARYNINJACOREAPI BNVersionInfo BNPluginGetMaximumVersionInfo(BNRepoPlugin* p);
7221+
// BINARYNINJACOREAPI const char* BNPluginGetLongdescription(BNRepoPlugin* p);
7222+
// BINARYNINJACOREAPI BNVersionInfo BNPluginGetMinimumVersionInfo(BNRepoPlugin* p);
7223+
// BINARYNINJACOREAPI BNVersionInfo BNPluginGetMaximumVersionInfo(BNRepoPlugin* p);
72247224
BINARYNINJACOREAPI BNVersionInfo BNParseVersionString(const char* v);
72257225
BINARYNINJACOREAPI bool BNVersionLessThan(const BNVersionInfo smaller, const BNVersionInfo larger);
72267226
BINARYNINJACOREAPI const char* BNPluginGetName(BNRepoPlugin* p);
72277227
BINARYNINJACOREAPI const char* BNPluginGetProjectUrl(BNRepoPlugin* p);
7228-
BINARYNINJACOREAPI const char* BNPluginGetPackageUrl(BNRepoPlugin* p);
7229-
BINARYNINJACOREAPI const char* BNPluginGetAuthorUrl(BNRepoPlugin* p);
7230-
BINARYNINJACOREAPI const char* BNPluginGetVersion(BNRepoPlugin* p);
7231-
BINARYNINJACOREAPI const char* BNPluginGetCommit(BNRepoPlugin* p);
7232-
BINARYNINJACOREAPI const bool BNPluginGetViewOnly(BNRepoPlugin* p);
7228+
// BINARYNINJACOREAPI const char* BNPluginGetPackageUrl(BNRepoPlugin* p);
7229+
// BINARYNINJACOREAPI const char* BNPluginGetVersions(BNRepoPlugin* p);
7230+
// BINARYNINJACOREAPI const bool BNPluginGetViewOnly(BNRepoPlugin* p);
72337231
BINARYNINJACOREAPI void BNFreePluginTypes(BNPluginType* r);
72347232
BINARYNINJACOREAPI BNRepoPlugin* BNNewPluginReference(BNRepoPlugin* r);
72357233
BINARYNINJACOREAPI void BNFreePlugin(BNRepoPlugin* plugin);
72367234
BINARYNINJACOREAPI const char* BNPluginGetPath(BNRepoPlugin* p);
7237-
BINARYNINJACOREAPI const char* BNPluginGetSubdir(BNRepoPlugin* p);
7238-
BINARYNINJACOREAPI const char* BNPluginGetDependencies(BNRepoPlugin* p);
7235+
// BINARYNINJACOREAPI const char* BNPluginGetSubdir(BNRepoPlugin* p);
7236+
// BINARYNINJACOREAPI const char* BNPluginGetDependencies(BNRepoPlugin* p);
72397237
BINARYNINJACOREAPI bool BNPluginIsInstalled(BNRepoPlugin* p);
72407238
BINARYNINJACOREAPI bool BNPluginIsEnabled(BNRepoPlugin* p);
72417239
BINARYNINJACOREAPI BNPluginStatus BNPluginGetPluginStatus(BNRepoPlugin* p);
72427240
BINARYNINJACOREAPI BNPluginType* BNPluginGetPluginTypes(BNRepoPlugin* p, size_t* count);
72437241
BINARYNINJACOREAPI bool BNPluginEnable(BNRepoPlugin* p, bool force);
72447242
BINARYNINJACOREAPI bool BNPluginDisable(BNRepoPlugin* p);
7245-
BINARYNINJACOREAPI bool BNPluginInstall(BNRepoPlugin* p);
7246-
BINARYNINJACOREAPI bool BNPluginInstallDependencies(BNRepoPlugin* p);
7243+
// BINARYNINJACOREAPI bool BNPluginInstall(BNRepoPlugin* p);
7244+
// BINARYNINJACOREAPI bool BNPluginInstallDependencies(BNRepoPlugin* p);
72477245
BINARYNINJACOREAPI bool BNPluginUninstall(BNRepoPlugin* p);
72487246
BINARYNINJACOREAPI bool BNPluginUpdate(BNRepoPlugin* p);
7249-
BINARYNINJACOREAPI char** BNPluginGetPlatforms(BNRepoPlugin* p, size_t* count);
7250-
BINARYNINJACOREAPI void BNFreePluginPlatforms(char** platforms, size_t count);
7247+
// BINARYNINJACOREAPI void BNFreePluginPlatforms(char** platforms, size_t count);
72517248
BINARYNINJACOREAPI const char* BNPluginGetRepository(BNRepoPlugin* p);
72527249
BINARYNINJACOREAPI bool BNPluginIsBeingDeleted(BNRepoPlugin* p);
72537250
BINARYNINJACOREAPI bool BNPluginIsBeingUpdated(BNRepoPlugin* p);
@@ -7258,8 +7255,7 @@ extern "C"
72587255
BINARYNINJACOREAPI bool BNPluginIsUpdateAvailable(BNRepoPlugin* p);
72597256
BINARYNINJACOREAPI bool BNPluginAreDependenciesBeingInstalled(BNRepoPlugin* p);
72607257

7261-
BINARYNINJACOREAPI char* BNPluginGetProjectData(BNRepoPlugin* p);
7262-
BINARYNINJACOREAPI uint64_t BNPluginGetLastUpdate(BNRepoPlugin* p);
7258+
// BINARYNINJACOREAPI uint64_t BNPluginGetLastUpdate(BNRepoPlugin* p);
72637259

72647260
BINARYNINJACOREAPI BNRepository* BNNewRepositoryReference(BNRepository* r);
72657261
BINARYNINJACOREAPI void BNFreeRepository(BNRepository* r);
@@ -7271,7 +7267,6 @@ extern "C"
72717267
BINARYNINJACOREAPI BNRepoPlugin* BNRepositoryGetPluginByPath(BNRepository* r, const char* pluginPath);
72727268
BINARYNINJACOREAPI const char* BNRepositoryGetPluginsPath(BNRepository* r);
72737269

7274-
BINARYNINJACOREAPI BNRepositoryManager* BNCreateRepositoryManager(const char* enabledPluginsPath);
72757270
BINARYNINJACOREAPI BNRepositoryManager* BNNewRepositoryManagerReference(BNRepositoryManager* r);
72767271
BINARYNINJACOREAPI void BNFreeRepositoryManager(BNRepositoryManager* r);
72777272
BINARYNINJACOREAPI bool BNRepositoryManagerCheckForUpdates(BNRepositoryManager* r);

0 commit comments

Comments
 (0)