Remove Vestigial + cxx 20 fix

Author: 0cyn

view/kernelcache/HeadlessPlugin.cpp

@@ -5,7 +5,6 @@
 #ifdef __cplusplus
 extern "C" {
 #endif
-	// extern void RegisterSharedCacheWorkflow();
 #ifdef __cplusplus
 }
 #endif

view/kernelcache/core/KernelCacheController.h

@@ -12,10 +12,6 @@ DECLARE_KC_API_OBJECT(BNKernelCacheController, KernelCacheController);
 void RegisterKernelCacheControllerDestructor();
 
 namespace BinaryNinja::KC {
-	static const char* METADATA_KEY = "kernel_cache";
-	static const char* OLD_METADATA_KEY_COUNT = "KERNELCACHE-ModifiedState-Count";
-	static const char* OLD_METADATA_KEY_PREFIX = "KERNELCACHE-ModifiedState-";
-
 	// Represents the view state for a given `DSCache`
 	class KernelCacheController : public KCRefCountObject
 	{
@@ -50,4 +46,4 @@ namespace BinaryNinja::KC {
 
 		bool IsImageLoaded(const CacheImage& image);
 	};
-}  // namespace BinaryNinja::DSC
+}  // namespace BinaryNinja::KC

view/kernelcache/core/KernelCacheView.h

@@ -2,8 +2,8 @@
 // Created by kat on 5/23/23.
 //
 
-#ifndef SHAREDCACHE_DSCVIEW_H
-#define SHAREDCACHE_DSCVIEW_H
+#ifndef KERNELCACHE_KERNELCACHEVIEW_H
+#define KERNELCACHE_KERNELCACHEVIEW_H
 
 #include <binaryninjaapi.h>
 
@@ -60,4 +60,4 @@ class KernelCacheViewType : public BinaryNinja::BinaryViewType
 };
 
 
-#endif  // SHAREDCACHE_DSCVIEW_H
+#endif  // KERNELCACHE_KERNELCACHEVIEW_H

view/kernelcache/core/MachO.cpp

@@ -459,7 +459,7 @@ std::vector<CacheSymbol> KernelCacheMachOHeader::ReadSymbolTable(Ref<BinaryView>
 			nlist_64 nlist = {};
 			if (bv->GetAddressSize() == 4)
 			{
-				// 32-bit DSC
+				// 32-bit KC
 				struct nlist nlist32 = {};
 				reader.Seek(symbolInfo.address + (entryIndex * sizeof(nlist32)));
 				reader.Read(&nlist, sizeof(nlist32));
@@ -471,7 +471,7 @@ std::vector<CacheSymbol> KernelCacheMachOHeader::ReadSymbolTable(Ref<BinaryView>
 			}
 			else
 			{
-				// 64-bit DSC
+				// 64-bit KC
 				reader.Seek(symbolInfo.address + (entryIndex * sizeof(nlist)));
 				reader.Read(&nlist, sizeof(nlist));
 			}

view/kernelcache/core/refcountobject.h

@@ -58,9 +58,9 @@ namespace BinaryNinja::KC {
 #endif
 
 	public:
-		KCRef<T>() : m_obj(NULL) {}
+		KCRef() : m_obj(NULL) {}
 
-		KCRef<T>(T* obj) : m_obj(obj)
+		KCRef(T* obj) : m_obj(obj)
 		{
 			if (m_obj)
 			{
@@ -71,7 +71,7 @@ namespace BinaryNinja::KC {
 			}
 		}
 
-		KCRef<T>(const KCRef<T>& obj) : m_obj(obj.m_obj)
+		KCRef(const KCRef& obj) : m_obj(obj.m_obj)
 		{
 			if (m_obj)
 			{
@@ -82,7 +82,7 @@ namespace BinaryNinja::KC {
 			}
 		}
 
-		~KCRef<T>()
+		~KCRef()
 		{
 			if (m_obj)
 			{
@@ -94,7 +94,7 @@ namespace BinaryNinja::KC {
 		}
 
 		// move constructor
-		KCRef<T>(KCRef<T>&& other) : m_obj(other.m_obj)
+		KCRef(KCRef&& other) : m_obj(other.m_obj)
 		{
 			other.m_obj = 0;
 #ifdef BN_REF_COUNT_DEBUG

view/kernelcache/ui/symboltable.h

@@ -7,8 +7,8 @@
 #include <QStandardItemModel>
 #include "filter.h"
 
-#ifndef BINARYNINJA_DSCSYMBOLTABLE_H
-#define BINARYNINJA_DSCSYMBOLTABLE_H
+#ifndef BINARYNINJA_KCSYMBOLTABLE_H
+#define BINARYNINJA_KCSYMBOLTABLE_H
 
 class SymbolTableView;
 
@@ -99,4 +99,4 @@ Q_OBJECT
 };
 
 
-#endif  // BINARYNINJA_DSCSYMBOLTABLE_H
+#endif  // BINARYNINJA_KCSYMBOLTABLE_H