Skip to content

Commit 5b804c2

Browse files
committed
fix triage entropy graph navigation for mapped files
1 parent 4023131 commit 5b804c2

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

examples/triage/entropy.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ EntropyWidget::EntropyWidget(QWidget* parent, TriageView* view, BinaryViewRef da
7474
timer->setSingleShot(false);
7575
timer->start();
7676

77+
setCursor(Qt::PointingHandCursor);
7778
setMinimumHeight(UIContext::getScaledWindowSize(32, 32).height());
7879
}
7980

examples/triage/view.cpp

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -229,15 +229,11 @@ void TriageView::navigateToFileOffset(uint64_t offset)
229229
return;
230230
if (!hasAddr)
231231
frame->navigate("Hex:Raw", offset);
232-
else if (BinaryNinja::Settings::Instance()->Get<bool>("ui.view.graph.preferred") &&
233-
frame->getCurrentBinaryView() &&
234-
frame->getCurrentBinaryView()->GetAnalysisFunctionsForAddress(offset).size() > 0)
235-
{
236-
frame->navigate("Graph:" + frame->getCurrentDataType(), offset);
237-
}
238232
else
239233
{
240-
frame->navigate("Linear:" + frame->getCurrentDataType(), offset);
234+
QString viewType = BinaryNinja::Settings::Instance()->Get<bool>("ui.view.graph.preferred") ? "Graph" : "Linear";
235+
QString dataType = QString::fromStdString(m_data->GetTypeName());
236+
frame->navigate(viewType + ":" + dataType, addr);
241237
}
242238
}
243239
else

python/examples/triage/entropy.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ def __init__(self, parent, view, data):
5353
self.timer.setSingleShot(False)
5454
self.timer.start()
5555

56+
self.setCursor(Qt.PointingHandCursor)
5657
self.setMinimumHeight(UIContext.getScaledWindowSize(32, 32).height())
5758

5859
def paintEvent(self, event):

python/examples/triage/view.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,9 @@ def navigateToFileOffset(self, offset):
151151
if addr is None:
152152
view_frame.navigate("Hex:Raw", offset)
153153
else:
154-
view_frame.navigate("Linear:" + view_frame.getCurrentDataType(), addr)
154+
view_type = "Graph" if Settings().get_bool("ui.view.graph.preferred") else "Linear"
155+
data_type = self.data.view_type
156+
view_frame.navigate(f"{view_type}:{data_type}", addr)
155157
else:
156158
if self.data == self.data.file.raw:
157159
addr = offset

0 commit comments

Comments
 (0)