Skip to content

Commit 5ee61e3

Browse files
committed
[ObjC] Remove unnecesary BeginUndoActions / ForgetUndoActions
The symbol creation code in `ObjCProcessor` was updated to avoid creating undo actions some time ago, but removing these calls was missed due to the timing of when the PR that introduced them was merged.
1 parent 7ac5e43 commit 5ee61e3

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

objectivec/objc.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1770,10 +1770,8 @@ void ObjCProcessor::ProcessNSConstantArrays()
17701770
DefineObjCSymbol(DataSymbol, Type::NamedType(m_data, m_typeNames.nsConstantArray),
17711771
fmt::format("nsarray_{:x}", i), i, true);
17721772
}
1773-
auto id = m_data->BeginUndoActions();
17741773
ScopedSymbolQueue::Get().Process();
17751774
m_data->EndBulkModifySymbols();
1776-
m_data->ForgetUndoActions(id);
17771775
}
17781776

17791777
}
@@ -1813,10 +1811,8 @@ void ObjCProcessor::ProcessNSConstantDictionaries()
18131811
DefineObjCSymbol(DataSymbol, Type::NamedType(m_data, m_typeNames.nsConstantDictionary),
18141812
fmt::format("nsdict_{:x}", i), i, true);
18151813
}
1816-
auto id = m_data->BeginUndoActions();
18171814
ScopedSymbolQueue::Get().Process();
18181815
m_data->EndBulkModifySymbols();
1819-
m_data->ForgetUndoActions(id);
18201816
}
18211817
}
18221818

@@ -1870,10 +1866,8 @@ void ObjCProcessor::ProcessNSConstantIntegerNumbers()
18701866
continue;
18711867
}
18721868
}
1873-
auto id = m_data->BeginUndoActions();
18741869
ScopedSymbolQueue::Get().Process();
18751870
m_data->EndBulkModifySymbols();
1876-
m_data->ForgetUndoActions(id);
18771871
}
18781872
}
18791873

@@ -1960,10 +1954,8 @@ void ObjCProcessor::ProcessNSConstantFloatingPointNumbers()
19601954
}
19611955
DefineObjCSymbol(DataSymbol, Type::NamedType(m_data, *typeName), name, i, true);
19621956
}
1963-
auto id = m_data->BeginUndoActions();
19641957
ScopedSymbolQueue::Get().Process();
19651958
m_data->EndBulkModifySymbols();
1966-
m_data->ForgetUndoActions(id);
19671959
}
19681960
}
19691961

@@ -1996,10 +1988,8 @@ void ObjCProcessor::ProcessNSConstantDatas()
19961988
DefineObjCSymbol(
19971989
DataSymbol, Type::NamedType(m_data, m_typeNames.nsConstantData), fmt::format("nsdata_{:x}", i), i, true);
19981990
}
1999-
auto id = m_data->BeginUndoActions();
20001991
ScopedSymbolQueue::Get().Process();
20011992
m_data->EndBulkModifySymbols();
2002-
m_data->ForgetUndoActions(id);
20031993
}
20041994
}
20051995

0 commit comments

Comments
 (0)