Add more reserve calls

Author: SmoothHacker

architecture.cpp

@@ -1699,6 +1699,7 @@ vector<Ref<TypeLibrary>> Architecture::GetTypeLibraries()
 	BNTypeLibrary** libs = BNGetArchitectureTypeLibraries(m_object, &count);
 
 	vector<Ref<TypeLibrary>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; ++i)
 	{
 		result.push_back(new TypeLibrary(BNNewTypeLibraryReference(libs[i])));
@@ -2133,6 +2134,7 @@ vector<NameAndType> CoreArchitecture::GetIntrinsicInputs(uint32_t intrinsic)
 	BNNameAndType* inputs = BNGetArchitectureIntrinsicInputs(m_object, intrinsic, &count);
 
 	vector<NameAndType> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		result.push_back(NameAndType(inputs[i].name,
@@ -2150,6 +2152,7 @@ vector<Confidence<Ref<Type>>> CoreArchitecture::GetIntrinsicOutputs(uint32_t int
 	BNTypeWithConfidence* outputs = BNGetArchitectureIntrinsicOutputs(m_object, intrinsic, &count);
 
 	vector<Confidence<Ref<Type>>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 		result.push_back(Confidence<Ref<Type>>(new Type(BNNewTypeReference(outputs[i].type)), outputs[i].confidence));
 

binaryview.cpp

@@ -3095,6 +3095,7 @@ unordered_set<QualifiedName> BinaryView::GetOutgoingRecursiveTypeReferences(cons
 {
 	size_t count;
 	vector<BNQualifiedName> apiTypes;
+	apiTypes.resize(types.size());
 	for (auto& type: types)
 	{
 		apiTypes.push_back(type.GetAPIObject());
@@ -3146,6 +3147,7 @@ unordered_set<QualifiedName> BinaryView::GetIncomingRecursiveTypeReferences(cons
 {
 	size_t count;
 	vector<BNQualifiedName> apiTypes;
+	apiTypes.reserve(types.size());
 	for (auto& type: types)
 	{
 		apiTypes.push_back(type.GetAPIObject());
@@ -4045,6 +4047,7 @@ vector<DerivedString> BinaryView::GetDerivedStrings()
 	size_t count;
 	BNDerivedString* strings = BNGetDerivedStrings(m_object, &count);
 	vector<DerivedString> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 		result.push_back(DerivedString::FromAPIObject(&strings[i], false));
 	BNFreeDerivedStringList(strings, count);
@@ -4281,10 +4284,12 @@ bool BinaryView::ParseTypesFromSource(const string& source, const vector<string>
 	}
 
 	vector<const char*> coreOptions;
+	coreOptions.reserve(options.size());
 	for (auto& option : options)
 		coreOptions.push_back(option.c_str());
 
 	vector<const char*> coreIncludeDirs;
+	coreIncludeDirs.reserve(includeDirs.size());
 	for (auto& includeDir : includeDirs)
 		coreIncludeDirs.push_back(includeDir.c_str());
 
@@ -4911,6 +4916,7 @@ bool BinaryView::DisassociateTypeArchiveType(const std::string& typeId)
 bool BinaryView::PullTypeArchiveTypes(const std::string& archiveId, const std::unordered_set<std::string>& archiveTypeIds, std::unordered_map<std::string, std::string>& updatedTypes)
 {
 	std::vector<const char*> apiArchiveTypeIds;
+	apiArchiveTypeIds.reserve(archiveTypeIds.size());
 	for (const auto& archiveTypeId: archiveTypeIds)
 	{
 		apiArchiveTypeIds.push_back(archiveTypeId.c_str());
@@ -4935,6 +4941,7 @@ bool BinaryView::PullTypeArchiveTypes(const std::string& archiveId, const std::u
 bool BinaryView::PushTypeArchiveTypes(const std::string& archiveId, const std::unordered_set<std::string>& typeIds, std::unordered_map<std::string, std::string>& updatedTypes)
 {
 	std::vector<const char*> apiTypeIds;
+	apiTypeIds.reserve(typeIds.size());
 	for (const auto& typeId: typeIds)
 	{
 		apiTypeIds.push_back(typeId.c_str());

collaboration.cpp

@@ -437,6 +437,7 @@ bool BinaryNinja::Collaboration::TypeArchiveConflictHandlerCallback(void* ctxt,
 	if (!chctxt->callback)
 		return true;
 	std::vector<Ref<TypeArchiveMergeConflict>> conflictVec;
+	conflictVec.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		conflictVec.push_back(new TypeArchiveMergeConflict(conflicts[i]));
@@ -658,6 +659,7 @@ std::vector<std::pair<std::string, std::string>> Remote::GetAuthBackends()
 		throw RemoteException("Failed to get authentication backends");
 
 	std::vector<std::pair<std::string, std::string>> results;
+	results.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		results.push_back({methods[i], names[i]});
@@ -855,6 +857,7 @@ std::vector<std::pair<uint64_t, std::string>> Remote::SearchGroups(const std::st
 		throw RemoteException("Failed to search groups");
 
 	std::vector<std::pair<uint64_t, std::string>> results;
+	results.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		results.push_back({ids[i], names[i]});
@@ -965,6 +968,7 @@ std::vector<std::pair<std::string, std::string>> Remote::SearchUsers(const std::
 		throw RemoteException("Failed to search users");
 
 	std::vector<std::pair<std::string, std::string>> results;
+	results.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		results.push_back({ids[i], names[i]});
@@ -2527,6 +2531,7 @@ std::vector<std::string> CollabSnapshot::GetParentIds()
 	size_t count = 0;
 	char** strs = BNCollaborationSnapshotGetParentIds(m_object, &count);
 	std::vector<std::string> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		result.push_back(strs[i]);
@@ -2541,6 +2546,7 @@ std::vector<std::string> CollabSnapshot::GetChildIds()
 	size_t count = 0;
 	char** strs = BNCollaborationSnapshotGetParentIds(m_object, &count);
 	std::vector<std::string> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		result.push_back(strs[i]);

database.cpp

@@ -248,6 +248,7 @@ vector<Ref<Snapshot>> Snapshot::GetParents()
 	size_t count;
 	BNSnapshot** parents = BNGetSnapshotParents(m_object, &count);
 	vector<Ref<Snapshot>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		result.push_back(new Snapshot(BNNewSnapshotReference(parents[i])));
@@ -262,6 +263,7 @@ vector<Ref<Snapshot>> Snapshot::GetChildren()
 	size_t count;
 	BNSnapshot** children = BNGetSnapshotChildren(m_object, &count);
 	vector<Ref<Snapshot>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		result.push_back(new Snapshot(BNNewSnapshotReference(children[i])));
@@ -323,6 +325,7 @@ vector<Ref<UndoEntry>> Snapshot::GetUndoEntries(const ProgressFunction& progress
 	}
 
 	vector<Ref<UndoEntry>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		result.push_back(new UndoEntry(BNNewUndoEntryReference(entries[i])));
@@ -390,6 +393,7 @@ vector<Ref<Snapshot>> Database::GetSnapshots()
 	size_t count;
 	BNSnapshot** snapshots = BNGetDatabaseSnapshots(m_object, &count);
 	vector<Ref<Snapshot>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 		result.push_back(new Snapshot(BNNewSnapshotReference(snapshots[i])));
 	BNFreeSnapshotList(snapshots, count);
@@ -455,6 +459,7 @@ std::vector<std::string> Database::GetGlobalKeys() const
 	}
 
 	std::vector<std::string> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		result.push_back(value[i]);

debuginfo.cpp

@@ -44,6 +44,7 @@ vector<string> DebugInfo::GetParsers() const
 	char** parsers = BNGetDebugParserNames(m_object, &count);
 
 	vector<string> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; ++i)
 	{
 		result.emplace_back(parsers[i]);
@@ -70,6 +71,7 @@ vector<NameAndType> DebugInfo::GetTypes(const string& parserName) const
 		return {};
 
 	vector<NameAndType> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; ++i)
 	{
 		result.emplace_back(nameAndTypes[i].name,
@@ -136,6 +138,7 @@ vector<DataVariableAndName> DebugInfo::GetDataVariables(const string& parserName
 		return {};
 
 	vector<DataVariableAndName> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; ++i)
 	{
 		result.emplace_back(variablesAndName[i].address,
@@ -193,6 +196,7 @@ vector<tuple<string, Ref<Type>>> DebugInfo::GetTypesByName(const string& name) c
 		return {};
 
 	vector<tuple<string, Ref<Type>>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; ++i)
 	{
 		result.emplace_back(namesAndTypes[i].name, Ref<Type>(new Type(BNNewTypeReference(namesAndTypes[i].type))));
@@ -213,6 +217,7 @@ vector<tuple<string, uint64_t, Ref<Type>>> DebugInfo::GetDataVariablesByName(con
 		return {};
 
 	vector<tuple<string, uint64_t, Ref<Type>>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; ++i)
 	{
 		result.emplace_back(variablesAndName[i].name, variablesAndName[i].address,
@@ -234,6 +239,7 @@ vector<tuple<string, string, Ref<Type>>> DebugInfo::GetDataVariablesByAddress(co
 		return {};
 
 	vector<tuple<string, string, Ref<Type>>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; ++i)
 	{
 		result.emplace_back(variablesAndName[i].parser, variablesAndName[i].name,
@@ -376,6 +382,7 @@ vector<Ref<DebugInfoParser>> DebugInfoParser::GetList()
 	BNDebugInfoParser** parsers = BNGetDebugInfoParsers(&count);
 
 	vector<Ref<DebugInfoParser>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; ++i)
 	{
 		result.emplace_back(new DebugInfoParser(BNNewDebugInfoParserReference(parsers[i])));
@@ -392,6 +399,7 @@ vector<Ref<DebugInfoParser>> DebugInfoParser::GetListForView(const Ref<BinaryVie
 	BNDebugInfoParser** parsers = BNGetDebugInfoParsersForView(data->GetObject(), &count);
 
 	vector<Ref<DebugInfoParser>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; ++i)
 	{
 		result.emplace_back(new DebugInfoParser(BNNewDebugInfoParserReference(parsers[i])));

demangle.cpp

@@ -191,6 +191,7 @@ namespace BinaryNinja {
 		size_t count;
 		BNDemangler** list = BNGetDemanglerList(&count);
 		vector<Ref<Demangler>> result;
+		result.reserve(count);
 		for (size_t i = 0; i < count; i++)
 			result.push_back(new CoreDemangler(list[i]));
 		BNFreeDemanglerList(list);

downloadprovider.cpp

@@ -230,6 +230,7 @@ vector<Ref<DownloadProvider>> DownloadProvider::GetList()
 	size_t count;
 	BNDownloadProvider** list = BNGetDownloadProviderList(&count);
 	vector<Ref<DownloadProvider>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 		result.push_back(new CoreDownloadProvider(list[i]));
 	BNFreeDownloadProviderList(list);

enterprise.cpp

@@ -55,6 +55,7 @@ std::vector<std::pair<std::string, std::string>> BinaryNinja::Enterprise::GetAut
 	size_t count = BNGetEnterpriseServerAuthenticationMethods(&methods, &names);
 
 	std::vector<std::pair<std::string, std::string>> results;
+	results.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		results.push_back({methods[i], names[i]});

filemetadata.cpp

@@ -389,6 +389,7 @@ vector<Ref<UndoEntry>> FileMetadata::GetUndoEntries()
 	BNUndoEntry** entries = BNGetUndoEntries(m_object, &count);
 
 	vector<Ref<UndoEntry>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		result.push_back(new UndoEntry(BNNewUndoEntryReference(entries[i])));
@@ -404,6 +405,7 @@ vector<Ref<UndoEntry>> FileMetadata::GetRedoEntries()
 	BNUndoEntry** entries = BNGetRedoEntries(m_object, &count);
 
 	vector<Ref<UndoEntry>> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i++)
 	{
 		result.push_back(new UndoEntry(BNNewUndoEntryReference(entries[i])));

flowgraph.cpp

@@ -442,6 +442,7 @@ std::vector<RenderLayer*> FlowGraph::GetRenderLayers() const
 	size_t count = 0;
 	BNRenderLayer** layers = BNGetFlowGraphRenderLayers(m_object, &count);
 	std::vector<RenderLayer*> result;
+	result.reserve(count);
 	for (size_t i = 0; i < count; i ++)
 	{
 		result.push_back(new CoreRenderLayer(layers[i]));