Ensure ELFView only add segments in a Begin/EndBulkAddSegments context

plafosse · plafosse · commit 66b933288095 · 2025-08-14T10:13:21.000-04:00
diff --git a/view/elf/elfview.cpp b/view/elf/elfview.cpp
@@ -583,6 +583,7 @@ bool ElfView::Init()
 	vector<Elf64SectionHeader> relocSections, relocASections;
 	Elf64SectionHeader symbolTableSection;
 
+	BeginBulkAddSegments();
 	uint64_t segmentStart = 0;
 	for (size_t i = 1; i < m_elfSections.size(); i++)
 	{
@@ -700,6 +701,8 @@ bool ElfView::Init()
 				GetParentView()->AddAutoSection(sectionNames[i], m_elfSections[i].offset, m_elfSections[i].size, DefaultSectionSemantics, type, m_elfSections[i].align, m_elfSections[i].entrySize, linkedSection, infoSection, m_elfSections[i].info);
 		}
 	}
+
+	EndBulkAddSegments();
 	// Apply architecture and platform
 	if (!m_arch)
 	{

Original file line number	Diff line number	Diff line change
`@@ -583,6 +583,7 @@ bool ElfView::Init()`
`583`	`583`	`vector<Elf64SectionHeader> relocSections, relocASections;`
`584`	`584`	`Elf64SectionHeader symbolTableSection;`
`585`	`585`
	`586`	`+ BeginBulkAddSegments();`
`586`	`587`	`uint64_t segmentStart = 0;`
`587`	`588`	`for (size_t i = 1; i < m_elfSections.size(); i++)`
`588`	`589`	`{`
`@@ -700,6 +701,8 @@ bool ElfView::Init()`
`700`	`701`	`GetParentView()->AddAutoSection(sectionNames[i], m_elfSections[i].offset, m_elfSections[i].size, DefaultSectionSemantics, type, m_elfSections[i].align, m_elfSections[i].entrySize, linkedSection, infoSection, m_elfSections[i].info);`
`701`	`702`	`}`
`702`	`703`	`}`
	`704`	`+`
	`705`	`+ EndBulkAddSegments();`
`703`	`706`	`// Apply architecture and platform`
`704`	`707`	`if (!m_arch)`
`705`	`708`	`{`