Fix memory leak in Metadata::GetKeyValueStore()

plafosse · plafosse · commit 71d01ec39b9a · 2025-04-16T09:46:18.000-04:00
diff --git a/metadata.cpp b/metadata.cpp
@@ -320,6 +320,7 @@ map<std::string, Ref<Metadata>> Metadata::GetKeyValueStore() const
 	{
 		result[data->keys[i]] = new Metadata(data->values[i]);
 	}
+	BNFreeMetadataValueStore(data);
 	return result;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -320,6 +320,7 @@ map<std::string, Ref<Metadata>> Metadata::GetKeyValueStore() const`
`320`	`320`	`{`
`321`	`321`	`result[data->keys[i]] = new Metadata(data->values[i]);`
`322`	`322`	`}`
	`323`	`+ BNFreeMetadataValueStore(data);`
`323`	`324`	`return result;`
`324`	`325`	`}`
`325`	`326`