Merge https://github.com/Vector35/binaryninja-api into dev-mips

Author: v1X3Q0

.github/workflows/rust.yml

@@ -24,7 +24,7 @@ jobs:
       - name: Install Rust
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: 1.77.0
+          toolchain: 1.83.0
           profile: minimal
           override: true
           components: clippy

.gitignore

@@ -76,7 +76,6 @@ suite/binaryninja/
 build
 generator
 types/
-plugins/
 
 # Rust
 rust/**/*.swp

activity.cpp

@@ -5,8 +5,7 @@ using namespace BinaryNinja;
 using namespace std;
 
 
-Activity::Activity(const string& configuration, const std::function<void(Ref<AnalysisContext> analysisContext)>& action) :
-    m_action(action)
+Activity::Activity(const string& configuration, const std::function<void(Ref<AnalysisContext> analysisContext)>& action) : m_action(action)
 {
 	// LogError("API-Side Activity Constructed!");
 	m_object = BNCreateActivity(configuration.c_str(), this, Run);
@@ -15,6 +14,7 @@ Activity::Activity(const string& configuration, const std::function<void(Ref<Ana
 
 Activity::Activity(BNActivity* activity)
 {
+	// LogError("API-Side Activity Constructed!");
 	m_object = BNNewActivityReference(activity);
 }
 
@@ -27,6 +27,7 @@ Activity::~Activity()
 
 void Activity::Run(void* ctxt, BNAnalysisContext* analysisContext)
 {
+	// LogError("API-Side Activity Run!");
 	Activity* activity = (Activity*)ctxt;
 	Ref<AnalysisContext> ac = new AnalysisContext(BNNewAnalysisContextReference(analysisContext));
 	activity->m_action(ac);
@@ -35,6 +36,7 @@ void Activity::Run(void* ctxt, BNAnalysisContext* analysisContext)
 
 string Activity::GetName() const
 {
+	// LogError("API-Side Activity GetName!");
 	char* name = BNActivityGetName(m_object);
 	string result = name;
 	BNFreeString(name);

api-docs/cppdocs/DoxygenLayout.xml

@@ -4,7 +4,7 @@
   <navindex>
     <tab type="mainpage" visible="yes" title="Binary Ninja API"/>
     <tab type="pages" visible="yes" title="Binary Ninja API" intro=""/>
-    <tab type="modules" visible="yes" title="" intro=""/>
+    <tab type="topics" visible="yes" title="" intro=""/>
     <tab type="namespacelist" visible="yes" title="Namespaces" intro=""/>
     <tab type="interfaces" visible="yes" title="">
       <tab type="interfacelist" visible="yes" title="" intro=""/>

api-docs/cppdocs/README.md

@@ -2,8 +2,6 @@
 
 We currently use `doxygen` for our C++ documentation generation.
 
-> Note: Using anything newer than doxygen 1.9.4 will cause minor issues with the website whenever the selected theme conflicts with the OS/browser light/dark mode selection.
-
 Generating documentation with Doxygen couldn't be simpler. Just install it and run:
 
 ```
@@ -14,7 +12,7 @@ From this directory. The output will be stored in `html/`
 
 ## Installing doxygen
 
-The theme for our documentation works best with doxygen 1.9.0 - 1.9.4
+The theme for our documentation works best with doxygen 1.12.0
 
 ### macOS (Homebrew)
 

api-docs/cppdocs/build_min_docs.py

@@ -5,22 +5,24 @@
 # This allows shipping a few thousand fewer files in updates including C++ documentation.
 #
 # Usage:
-# install doxygen 1.9.4 (or this script will not work. running minification on a different version can cause
-# 						 real issues.)
-# python3 build_min_docs.py
+# install doxygen 1.12.0
+#
+# make html
+# OR
+# make docset
 # =-=--
 
-__DOXYGEN_REQUIRED_VERSION__ = "1.9.4"
+__DOXYGEN_REQUIRED_VERSION__ = "1.12.0"
 
 import argparse
 import os
 import sys
 import json
 from collections import namedtuple
-from typing import List
 import subprocess
 import shutil
 
+doxygen = "doxygen" #to make testing other versions easier
 
 def system_with_output(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE):
 	proc = subprocess.Popen("" + cmd,
@@ -66,7 +68,7 @@ def load_items_in_file(filename):
 	"""
 	Recursively load in the text of file {filename} and all subfiles referenced by it.
 
-	:param filename: Target root filename. e.g. 'modules.js'
+	:param filename: Target root filename. e.g. 'topics.js'
 	:return: Combined text of javascript file tree.
 	"""
 	items = []
@@ -87,7 +89,7 @@ def minifier():
 	# 	add them to the top of the navbar.js file itself.
 
 	navtree_built_data = ""
-	for mod in load_items_in_file("html/modules.js"):
+	for mod in load_items_in_file("html/topics.js"):
 		navtree_built_data += mod + "\n"
 	for mod in load_items_in_file("html/namespaces.js"):
 		navtree_built_data += mod + "\n"
@@ -115,8 +117,8 @@ def minifier():
 	# Here, we just want to skip the whole process and immediately call the callback.
 	nav_tree_fixed_get_script = "function getScript(scriptName,func,show) { func(); }"
 
-	navtree_before_get_script = navtree_orig.split("function getScript(scriptName,func,show)")[0]
-	navtree_after_get_script = navtree_orig.split("function getScript(scriptName,func,show)")[1].split('}', 1)[1]
+	navtree_before_get_script = navtree_orig.split("const getScript = function(scriptName,func) {")[0]
+	navtree_after_get_script = navtree_orig.split("const getScript = function(scriptName,func) {")[1].split('}', 1)[1]
 
 	nav_tree_fixed = navtree_before_get_script + nav_tree_fixed_get_script + navtree_after_get_script
 	navtree = navtree_built_data + "\n" + nav_tree_fixed
@@ -130,9 +132,8 @@ def build_doxygen(args):
 	if not os.path.exists('./Doxyfile-HTML'):
 		print('No Doxyfile found. Are you in the right directory?')
 		sys.exit(1)
-	_, vers, _ = system_with_output("doxygen -V")
+	_, vers, _ = system_with_output(f"{doxygen} -V")
 	if __DOXYGEN_REQUIRED_VERSION__ not in vers.strip():
-		print(f'Please use Doxygen {__DOXYGEN_REQUIRED_VERSION__} to build documentation')
 		print(f'Please use Doxygen {__DOXYGEN_REQUIRED_VERSION__} to build documentation')
 		sys.exit(1)
 
@@ -154,9 +155,9 @@ def build_doxygen(args):
 	print(f'Building doxygen docs...')
 
 	if args.docset:
-		stat, out, err = system_with_output("doxygen Doxyfile-Docset")
+		stat, out, err = system_with_output(f"{doxygen} Doxyfile-Docset")
 	else:
-		stat, out, err = system_with_output("doxygen Doxyfile-HTML")
+		stat, out, err = system_with_output(f"{doxygen} Doxyfile-HTML")
 	print(f"Built Doxygen with status code {stat}")
 	print("Output dir is ./html/")
 	stat, out, err = system_with_output("cp _static/img/* html/")

api-docs/cppdocs/custom.css

@@ -67,6 +67,10 @@ input#MSearchField {
     top: -1px;
 }
 
+#MSearchSelect {
+    background-repeat: no-repeat !important;
+}
+
 /* Replicating an "undecorated root node" */
 
 .children_ul a.index\.html {
@@ -193,4 +197,4 @@ img.thread {
 
 .dark-mode img.thread {
     filter: invert(0.7);
-}
+}

api-docs/cppdocs/make.bat

@@ -0,0 +1,31 @@
+@echo off
+set PYTHON=poetry run python
+
+if "%1" == "help" (
+    echo Please use `make <target>` where <target> is one of
+    echo   clean    to clean the folders
+    echo   html     to make standalone HTML files
+    echo   docset   to make a Dash docset
+    exit /b
+)
+
+if "%1" == "clean" (
+    rmdir /s /q html
+    rmdir /s /q docset
+    rmdir /s /q xml
+    exit /b
+)
+
+if "%1" == "html" (
+    %PYTHON% build_min_docs.py
+    exit /b
+)
+
+if "%1" == "docset" (
+    %PYTHON% build_min_docs.py --docset
+    exit /b
+)
+
+echo Unknown target: %1
+exit /b 1
+

arch/arm64/arch_arm64.cpp

@@ -2722,6 +2722,26 @@ class AppleArm64CallingConvention: public Arm64CallingConvention
 };
 
 
+class AppleArm64ObjcFastARCCallingConvention: public Arm64CallingConvention
+{
+	uint32_t m_reg;
+	 public:
+	AppleArm64ObjcFastARCCallingConvention(Architecture* arch, uint32_t reg): Arm64CallingConvention(arch, "apple-arm64-objc-fast-arc-" + to_string(reg - REG_X0)), m_reg(reg)
+	{
+	}
+
+	virtual vector<uint32_t> GetIntegerArgumentRegisters() override
+	{
+		return vector<uint32_t> {m_reg};
+	}
+
+	virtual bool AreArgumentRegistersUsedForVarArgs() override
+	{
+		return false;
+	}
+};
+
+
 class LinuxArm64SystemCallConvention: public CallingConvention
 {
  public:
@@ -3583,6 +3603,14 @@ extern "C"
 		conv = new AppleArm64CallingConvention(arm64);
 		arm64->RegisterCallingConvention(conv);
 
+		for (uint32_t i = REG_X0; i <= REG_X28; i++)
+		{
+			if (i == REG_X16 || i == REG_X17 || i == REG_X18) // reserved by os.
+				continue;
+			conv = new AppleArm64ObjcFastARCCallingConvention(arm64, i);
+			arm64->RegisterCallingConvention(conv);
+		}
+
 		// Register ARM64 specific PLT trampoline recognizer
 		arm64->RegisterFunctionRecognizer(new Arm64ImportedFunctionRecognizer());